From mboxrd@z Thu Jan 1 00:00:00 1970 From: Domenico Andreoli Subject: Re: [PATCH 2/6] ARM: bcm476x: Add system timer Date: Wed, 10 Oct 2012 01:04:03 +0200 Message-ID: <20121009230403.GB7758@glitch> References: <20121007015300.828366635@gmail.com> <20121007015406.470633343@gmail.com> <1822741.oh36baA1m8@flexo> <50738F48.5010002@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <50738F48.5010002-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Stephen Warren Cc: Domenico Andreoli , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Florian Fainelli , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Oct 08, 2012 at 08:43:20PM -0600, Stephen Warren wrote: > On 10/08/2012 05:50 AM, Florian Fainelli wrote: > > On Sunday 07 October 2012 03:53:02 Domenico Andreoli wrote: > >> From: Domenico Andreoli > >> > >> System timer implementation for the BCM476x SoCs. > > >> Index: b/arch/arm/boot/dts/bcm476x.dtsi > > >> + timer { > >> + compatible = "brcm,bcm476x-system-timer"; > >> + reg = <0xba000 0x1000>; > >> + interrupt-parent = <&vic0>; > >> + interrupts = <4>, <11>; > >> + clock-frequency = <24000000>; > >> + }; > > > > This should rather be timer: timer@ba0000 for this node to be uniquely named. > > I only see 1 timer node in this series, so "timer" is already unique, > isn't it? I don't mind to add the address, this SoC actually has three timer blocks. Dome