From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Kent Yoder <key@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v2] TPM: Provide a tpm_tis OF driver
Date: Fri, 12 Oct 2012 14:20:05 -0600 [thread overview]
Message-ID: <20121012202005.GL4124@obsidianresearch.com> (raw)
In-Reply-To: <20121010162428.GA5013@ennui.austin.ibm.com>
On Wed, Oct 10, 2012 at 11:24:28AM -0500, Kent Yoder wrote:
> Why change the structs to const here? This generates warnings for me:
I should have dropped this, I was added when I added the __devinitdata
annotations..
> > +
> > +static struct platform_driver tis_driver = {
> > .driver = {
> > .name = "tpm_tis",
> > .owner = THIS_MODULE,
> > .pm = &tpm_tis_pm,
> > + .of_match_table = of_match_ptr(tis_of_platform_match),
> > },
>
> Patch v2 removes the ifdef around of_match_table, which now generates
> an error:
Yes, this update was following the style of other drivers. Obviously I
never thought to try this on x86 (only PPC), so I will try to setup a
compile for that as well and send v3.
I suspect this is simply a missing #include.
Regards,
Jason
prev parent reply other threads:[~2012-10-12 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 21:04 [PATCH v2] TPM: Provide a tpm_tis OF driver Jason Gunthorpe
2012-10-10 16:24 ` Kent Yoder
2012-10-12 20:20 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012202005.GL4124@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=key@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).