From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 08/10] pinctrl: single: support pinconf generic Date: Fri, 19 Oct 2012 12:13:33 -0700 Message-ID: <20121019191333.GT4730@atomide.com> References: <1350551224-12857-1-git-send-email-haojian.zhuang@gmail.com> <1350551224-12857-8-git-send-email-haojian.zhuang@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1350551224-12857-8-git-send-email-haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Haojian Zhuang Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org * Haojian Zhuang [121018 02:08]: > Add pinconf generic support with POWER SOURCE, BIAS PULL. ... > + case PIN_CONFIG_POWER_SOURCE: > + if (pcs->psmask == PCS_OFF_DISABLED > + || pcs->psshift == PCS_OFF_DISABLED) > + return -ENOTSUPP; > + data &= pcs->psmask; > + data = data >> pcs->psshift; > + *config = data; > + return 0; > + break; Hmm, only slightly related to this patch, mostly a generic question to others: Do others have any mux registers with status bits for things like PIN_CONFIG_POWER_SOURCE? I could use PIN_CONFIG_POWER_SOURCE for controlling the PBIAS for omap MMC. But there's also a status bit that needs to be checked for that. I think there was some other similar mux register for USB PHY that has a status register. So I'm wondering should the checking for status bit be handled in the pinctrl consume driver? Or should we have some bindings for that? Regards, Tony