devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	b-cousson-l0cyMroinI0@public.gmane.org
Subject: Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation
Date: Wed, 31 Oct 2012 11:29:03 -0700	[thread overview]
Message-ID: <20121031182903.GN12739@atomide.com> (raw)
In-Reply-To: <1351693612-23314-6-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>

* Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org> [121031 07:29]:
> The USB2 Host device node is extracted and used in the probe
> of the driver to initialize the usb ports and controller. The
> platform specific initialization is also performed.
> 
> Signed-off-by: Keshava Munegowda <keshava_mgowda-l0cyMroinI0@public.gmane.org>
> ---
>  arch/arm/mach-omap2/usb-host.c         |    2 -
>  drivers/mfd/omap-usb-host.c            |  163 +++++++++++++++++++++++---------
>  include/linux/platform_data/usb-omap.h |   19 +++-
>  3 files changed, 133 insertions(+), 51 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
> index d1dbe12..239c175 100644
> --- a/arch/arm/mach-omap2/usb-host.c
> +++ b/arch/arm/mach-omap2/usb-host.c
> @@ -502,8 +502,6 @@ void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
>  	}
>  	ehci_data.phy_reset = pdata->phy_reset;
>  	ohci_data.es2_compatibility = pdata->es2_compatibility;
> -	usbhs_data.ehci_data = &ehci_data;
> -	usbhs_data.ohci_data = &ohci_data;
>  
>  	if (cpu_is_omap34xx()) {
>  		setup_ehci_io_mux(pdata->port_mode);

Just checking.. Have you tested that these patches also
still work without device tree?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-10-31 18:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 14:26 [RESEND PATCH 00/11] ARM: OMAP: USB: Host: Device tree Adaptation Keshava Munegowda
2012-10-31 14:26 ` [RESEND PATCH 01/11] ARM: OMAP4: USB: Host: Add USB2 Host Device Tree Node Keshava Munegowda
2012-10-31 14:26 ` [RESEND PATCH 02/11] ARM: OMAP4: USB: Host: Panda board specific device tree node Keshava Munegowda
     [not found] ` <1351693612-23314-1-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-10-31 14:26   ` [RESEND PATCH 03/11] ARM: OMAP3: USB: Add USB2 Host Device Tree Node Keshava Munegowda
2012-10-31 14:26   ` [RESEND PATCH 04/11] ARM: OMAP3: USB: Host: Beagle-XM board specific device tree node Keshava Munegowda
2012-10-31 14:26   ` [RESEND PATCH 10/11] ARM: OMAP4: USB: Add pin mux configuration for panda board Keshava Munegowda
2012-10-31 14:26   ` [RESEND PATCH 11/11] ARM: OMAP3: USB: Add pin mux configuration for beagle-xm board Keshava Munegowda
2012-10-31 14:26 ` [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation Keshava Munegowda
     [not found]   ` <1351693612-23314-6-git-send-email-keshava_mgowda-l0cyMroinI0@public.gmane.org>
2012-10-31 18:29     ` Tony Lindgren [this message]
     [not found]       ` <20121031182903.GN12739-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-11-01  8:19         ` Munegowda, Keshava
2012-11-01 10:21           ` Felipe Balbi
2012-11-01 15:12             ` Munegowda, Keshava
2012-10-31 14:26 ` [RESEND PATCH 06/11] ARM: OMAP: USB: Host: USB TLL " Keshava Munegowda
2012-10-31 14:26 ` [RESEND PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data Keshava Munegowda
2012-10-31 14:26 ` [RESEND PATCH 08/11] ARM: OMAP: USB: Change the TLL clock names Keshava Munegowda
2012-10-31 14:26 ` [RESEND PATCH 09/11] ARM: OMAP: USB: Remove the device name for TLL channel clocks for OMAP3 Keshava Munegowda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121031182903.GN12739@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=b-cousson-l0cyMroinI0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=keshava_mgowda-l0cyMroinI0@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).