* [PATCH] ARM: EXYNOS5250: Add support for USB 3.0 dwc3 controller @ 2012-11-06 15:28 Vivek Gautam 2012-11-06 15:28 ` [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver Vivek Gautam 0 siblings, 1 reply; 7+ messages in thread From: Vivek Gautam @ 2012-11-06 15:28 UTC (permalink / raw) To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ, balbi-l0cyMroinI0, av.tikhomirov-Sze3O3UU22JBDgjK7y7TUQ, yulgon.kim-Sze3O3UU22JBDgjK7y7TUQ, thomas.abraham-QSEj5FYQhm4dnm+yROfE0A, p.paneri-Sze3O3UU22JBDgjK7y7TUQ Here we add the required support for device tree and further clocks and device reigster base address. Based on 'for-next' branch of linux-samsung tree. Tested with required driver DT patches for dwc3-exynos: http://www.spinics.net/lists/linux-usb/msg73857.html and USB 3.0 phy support patches: https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-November/021915.html Vivek Gautam (1): ARM: Exynos5250: Enabling dwc3-exynos driver arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ arch/arm/mach-exynos/clock-exynos5.c | 24 ++++++++++++++++++++++++ arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ drivers/usb/Kconfig | 1 + 5 files changed, 34 insertions(+), 0 deletions(-) -- 1.7.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver 2012-11-06 15:28 [PATCH] ARM: EXYNOS5250: Add support for USB 3.0 dwc3 controller Vivek Gautam @ 2012-11-06 15:28 ` Vivek Gautam 2012-11-06 16:43 ` Felipe Balbi 0 siblings, 1 reply; 7+ messages in thread From: Vivek Gautam @ 2012-11-06 15:28 UTC (permalink / raw) To: linux-samsung-soc, devicetree-discuss Cc: linux-usb, kgene.kim, balbi, av.tikhomirov, yulgon.kim, thomas.abraham, p.paneri Adding DWC3 device tree node for Exynos5250 along with the device address and clock support needed for the controller. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> --- arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ arch/arm/mach-exynos/clock-exynos5.c | 24 ++++++++++++++++++++++++ arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ drivers/usb/Kconfig | 1 + 5 files changed, 34 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index cf6a02d..52bca54 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -68,6 +68,12 @@ interrupts = <0 96 0>; }; + dwc3 { + compatible = "samsung,exynos-dwc3"; + reg = <0x12000000 0x10000>; + interrupts = <0 72 0>; + }; + rtc { compatible = "samsung,s3c6410-rtc"; reg = <0x101E0000 0x100>; diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c index a88e0d9..ee094ee 100644 --- a/arch/arm/mach-exynos/clock-exynos5.c +++ b/arch/arm/mach-exynos/clock-exynos5.c @@ -740,6 +740,11 @@ static struct clk exynos5_init_clocks_off[] = { .enable = exynos5_clk_ip_fsys_ctrl , .ctrlbit = (1 << 18), }, { + .name = "usbdrd30", + .parent = &exynos5_clk_aclk_200.clk, + .enable = exynos5_clk_ip_fsys_ctrl, + .ctrlbit = (1 << 19), + }, { .name = "usbotg", .enable = exynos5_clk_ip_fsys_ctrl, .ctrlbit = (1 << 7), @@ -1004,6 +1009,16 @@ struct clksrc_sources exynos5_clkset_group = { .nr_sources = ARRAY_SIZE(exynos5_clkset_group_list), }; +struct clk *exynos5_clkset_usbdrd30_list[] = { + [0] = &exynos5_clk_mout_mpll.clk, + [1] = &exynos5_clk_mout_cpll.clk, +}; + +struct clksrc_sources exynos5_clkset_usbdrd30 = { + .sources = exynos5_clkset_usbdrd30_list, + .nr_sources = ARRAY_SIZE(exynos5_clkset_usbdrd30_list), +}; + /* Possible clock sources for aclk_266_gscl_sub Mux */ static struct clk *clk_src_gscl_266_list[] = { [0] = &clk_ext_xtal_mux, @@ -1288,6 +1303,15 @@ static struct clksrc_clk exynos5_clksrcs[] = { .parent = &exynos5_clk_mout_cpll.clk, }, .reg_div = { .reg = EXYNOS5_CLKDIV_GEN, .shift = 4, .size = 3 }, + }, { + .clk = { + .name = "sclk_usbdrd30", + .enable = exynos5_clksrc_mask_fsys_ctrl, + .ctrlbit = (1 << 28), + }, + .sources = &exynos5_clkset_usbdrd30, + .reg_src = { .reg = EXYNOS5_CLKSRC_FSYS, .shift = 28, .size = 1 }, + .reg_div = { .reg = EXYNOS5_CLKDIV_FSYS0, .shift = 24, .size = 4 }, }, }; diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h index ef4958b..397fb9d 100644 --- a/arch/arm/mach-exynos/include/mach/map.h +++ b/arch/arm/mach-exynos/include/mach/map.h @@ -197,6 +197,7 @@ #define EXYNOS4_PA_EHCI 0x12580000 #define EXYNOS4_PA_OHCI 0x12590000 #define EXYNOS4_PA_HSPHY 0x125B0000 +#define EXYNOS5_PA_DRD 0x12000000 #define EXYNOS4_PA_MFC 0x13400000 #define EXYNOS4_PA_UART 0x13800000 diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c index ed37273..8896926 100644 --- a/arch/arm/mach-exynos/mach-exynos5-dt.c +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c @@ -86,6 +86,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { "exynos5-hdmi", NULL), OF_DEV_AUXDATA("samsung,exynos5-mixer", 0x14450000, "exynos5-mixer", NULL), + OF_DEV_AUXDATA("samsung,exynos-dwc3", EXYNOS5_PA_DRD, + "exynos-dwc3", NULL), {}, }; diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index 4c90b51..0454b8a 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -53,6 +53,7 @@ config USB_ARCH_HAS_EHCI # some non-PCI HCDs implement xHCI config USB_ARCH_HAS_XHCI boolean + default y if ARCH_EXYNOS5 default PCI menuconfig USB_SUPPORT -- 1.7.6.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver 2012-11-06 15:28 ` [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver Vivek Gautam @ 2012-11-06 16:43 ` Felipe Balbi [not found] ` <20121106164304.GD3993-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Felipe Balbi @ 2012-11-06 16:43 UTC (permalink / raw) To: Vivek Gautam Cc: linux-samsung-soc, devicetree-discuss, linux-usb, kgene.kim, balbi, av.tikhomirov, yulgon.kim, thomas.abraham, p.paneri [-- Attachment #1: Type: text/plain, Size: 2575 bytes --] On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: > Adding DWC3 device tree node for Exynos5250 along with the > device address and clock support needed for the controller. > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > --- > arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ > arch/arm/mach-exynos/clock-exynos5.c | 24 ++++++++++++++++++++++++ > arch/arm/mach-exynos/include/mach/map.h | 1 + > arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ > drivers/usb/Kconfig | 1 + > 5 files changed, 34 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index cf6a02d..52bca54 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -68,6 +68,12 @@ > interrupts = <0 96 0>; > }; > > + dwc3 { shouldn't this be usb@12000000 ?? > + compatible = "samsung,exynos-dwc3"; > + reg = <0x12000000 0x10000>; > + interrupts = <0 72 0>; > + }; > + > rtc { > compatible = "samsung,s3c6410-rtc"; > reg = <0x101E0000 0x100>; > diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c > index a88e0d9..ee094ee 100644 > --- a/arch/arm/mach-exynos/clock-exynos5.c > +++ b/arch/arm/mach-exynos/clock-exynos5.c > @@ -740,6 +740,11 @@ static struct clk exynos5_init_clocks_off[] = { > .enable = exynos5_clk_ip_fsys_ctrl , > .ctrlbit = (1 << 18), > }, { > + .name = "usbdrd30", > + .parent = &exynos5_clk_aclk_200.clk, > + .enable = exynos5_clk_ip_fsys_ctrl, > + .ctrlbit = (1 << 19), > + }, { > .name = "usbotg", > .enable = exynos5_clk_ip_fsys_ctrl, > .ctrlbit = (1 << 7), > @@ -1004,6 +1009,16 @@ struct clksrc_sources exynos5_clkset_group = { > .nr_sources = ARRAY_SIZE(exynos5_clkset_group_list), > }; > > +struct clk *exynos5_clkset_usbdrd30_list[] = { > + [0] = &exynos5_clk_mout_mpll.clk, > + [1] = &exynos5_clk_mout_cpll.clk, looks like [0] and [1] indexes are unnecessary ?!? Not sure about mach-exynos' preferred array initialization style, though ;-) > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index 4c90b51..0454b8a 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -53,6 +53,7 @@ config USB_ARCH_HAS_EHCI > # some non-PCI HCDs implement xHCI > config USB_ARCH_HAS_XHCI > boolean > + default y if ARCH_EXYNOS5 NAK, this should be done on your arch/arm/mach-exynos/Kconfig. Just select USB_ARCH_HAS_XHCI. -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20121106164304.GD3993-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>]
* Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver [not found] ` <20121106164304.GD3993-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org> @ 2012-11-07 13:25 ` Vivek Gautam [not found] ` <CAFp+6iGFwTAvhamhoQszBL8QUau64XtDWGR1yX0azbuw1iWgVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Vivek Gautam @ 2012-11-07 13:25 UTC (permalink / raw) To: balbi-l0cyMroinI0 Cc: Vivek Gautam, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-usb-u79uwXL29TY76Z2rM5mHXA, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ, av.tikhomirov-Sze3O3UU22JBDgjK7y7TUQ, yulgon.kim-Sze3O3UU22JBDgjK7y7TUQ, Thomas Abraham, Praveen Paneri Hi, On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote: > On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: >> Adding DWC3 device tree node for Exynos5250 along with the >> device address and clock support needed for the controller. >> >> Signed-off-by: Vivek Gautam <gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> --- >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ >> arch/arm/mach-exynos/clock-exynos5.c | 24 ++++++++++++++++++++++++ >> arch/arm/mach-exynos/include/mach/map.h | 1 + >> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ >> drivers/usb/Kconfig | 1 + >> 5 files changed, 34 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi >> index cf6a02d..52bca54 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -68,6 +68,12 @@ >> interrupts = <0 96 0>; >> }; >> >> + dwc3 { > > shouldn't this be usb@12000000 ?? > Kept this in accordance with controller's name, similar to the change in following: http://www.mail-archive.com/linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg12800.html Needs to be changed ? >> + compatible = "samsung,exynos-dwc3"; >> + reg = <0x12000000 0x10000>; >> + interrupts = <0 72 0>; >> + }; >> + >> rtc { >> compatible = "samsung,s3c6410-rtc"; >> reg = <0x101E0000 0x100>; >> diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c >> index a88e0d9..ee094ee 100644 >> --- a/arch/arm/mach-exynos/clock-exynos5.c >> +++ b/arch/arm/mach-exynos/clock-exynos5.c >> @@ -740,6 +740,11 @@ static struct clk exynos5_init_clocks_off[] = { >> .enable = exynos5_clk_ip_fsys_ctrl , >> .ctrlbit = (1 << 18), >> }, { >> + .name = "usbdrd30", >> + .parent = &exynos5_clk_aclk_200.clk, >> + .enable = exynos5_clk_ip_fsys_ctrl, >> + .ctrlbit = (1 << 19), >> + }, { >> .name = "usbotg", >> .enable = exynos5_clk_ip_fsys_ctrl, >> .ctrlbit = (1 << 7), >> @@ -1004,6 +1009,16 @@ struct clksrc_sources exynos5_clkset_group = { >> .nr_sources = ARRAY_SIZE(exynos5_clkset_group_list), >> }; >> >> +struct clk *exynos5_clkset_usbdrd30_list[] = { >> + [0] = &exynos5_clk_mout_mpll.clk, >> + [1] = &exynos5_clk_mout_cpll.clk, > > looks like [0] and [1] indexes are unnecessary ?!? Not sure about > mach-exynos' preferred array initialization style, though ;-) > These are in sync with code-style in mach-exynos/clock-exynos5.c Probably this is how it is used with mach-exynos. >> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig >> index 4c90b51..0454b8a 100644 >> --- a/drivers/usb/Kconfig >> +++ b/drivers/usb/Kconfig >> @@ -53,6 +53,7 @@ config USB_ARCH_HAS_EHCI >> # some non-PCI HCDs implement xHCI >> config USB_ARCH_HAS_XHCI >> boolean >> + default y if ARCH_EXYNOS5 > > NAK, this should be done on your arch/arm/mach-exynos/Kconfig. Just > select USB_ARCH_HAS_XHCI. > Oops !! Sure, will move this to arch/arm/mach-exynos/Kconfig. > -- > balbi -- Thanks & Regards Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CAFp+6iGFwTAvhamhoQszBL8QUau64XtDWGR1yX0azbuw1iWgVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver [not found] ` <CAFp+6iGFwTAvhamhoQszBL8QUau64XtDWGR1yX0azbuw1iWgVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2012-11-07 16:43 ` Felipe Balbi 2012-11-07 17:18 ` Tomasz Figa 0 siblings, 1 reply; 7+ messages in thread From: Felipe Balbi @ 2012-11-07 16:43 UTC (permalink / raw) To: Vivek Gautam Cc: balbi-l0cyMroinI0, Vivek Gautam, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-usb-u79uwXL29TY76Z2rM5mHXA, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ, av.tikhomirov-Sze3O3UU22JBDgjK7y7TUQ, yulgon.kim-Sze3O3UU22JBDgjK7y7TUQ, Thomas Abraham, Praveen Paneri [-- Attachment #1: Type: text/plain, Size: 1768 bytes --] Hi, On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: > Hi, > > > On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote: > > On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: > >> Adding DWC3 device tree node for Exynos5250 along with the > >> device address and clock support needed for the controller. > >> > >> Signed-off-by: Vivek Gautam <gautam.vivek-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > >> --- > >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ > >> arch/arm/mach-exynos/clock-exynos5.c | 24 ++++++++++++++++++++++++ > >> arch/arm/mach-exynos/include/mach/map.h | 1 + > >> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ > >> drivers/usb/Kconfig | 1 + > >> 5 files changed, 34 insertions(+), 0 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > >> index cf6a02d..52bca54 100644 > >> --- a/arch/arm/boot/dts/exynos5250.dtsi > >> +++ b/arch/arm/boot/dts/exynos5250.dtsi > >> @@ -68,6 +68,12 @@ > >> interrupts = <0 96 0>; > >> }; > >> > >> + dwc3 { > > > > shouldn't this be usb@12000000 ?? > > > Kept this in accordance with controller's name, similar to the change > in following: > http://www.mail-archive.com/linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg12800.html > > Needs to be changed ? I'll leave it to DT experts, but I was under the impression that we should be using generic functionality names (usb, i2c, spi, uart, gpio, etc) instead of the IP name. IP name is something more for compatible flag. Don't take my word for it though :-) DT experts are the ones with final saying -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver 2012-11-07 16:43 ` Felipe Balbi @ 2012-11-07 17:18 ` Tomasz Figa 2012-11-08 5:06 ` Vivek Gautam 0 siblings, 1 reply; 7+ messages in thread From: Tomasz Figa @ 2012-11-07 17:18 UTC (permalink / raw) To: balbi Cc: Vivek Gautam, Vivek Gautam, linux-samsung-soc, devicetree-discuss, linux-usb, kgene.kim, av.tikhomirov, yulgon.kim, Thomas Abraham, Praveen Paneri Hi Vivek, Felipe, On Wednesday 07 of November 2012 18:43:22 Felipe Balbi wrote: > Hi, > > On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: > > Hi, > > > > On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi <balbi@ti.com> wrote: > > > On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: > > >> Adding DWC3 device tree node for Exynos5250 along with the > > >> device address and clock support needed for the controller. > > >> > > >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > > >> --- > > >> > > >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ > > >> arch/arm/mach-exynos/clock-exynos5.c | 24 > > >> ++++++++++++++++++++++++ > > >> arch/arm/mach-exynos/include/mach/map.h | 1 + > > >> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ > > >> drivers/usb/Kconfig | 1 + > > >> 5 files changed, 34 insertions(+), 0 deletions(-) > > >> > > >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi > > >> b/arch/arm/boot/dts/exynos5250.dtsi index cf6a02d..52bca54 100644 > > >> --- a/arch/arm/boot/dts/exynos5250.dtsi > > >> +++ b/arch/arm/boot/dts/exynos5250.dtsi > > >> @@ -68,6 +68,12 @@ > > >> > > >> interrupts = <0 96 0>; > > >> > > >> }; > > >> > > >> + dwc3 { > > > > > > shouldn't this be usb@12000000 ?? > > > > Kept this in accordance with controller's name, similar to the change > > in following: > > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg12800. > > html > > > > Needs to be changed ? > > I'll leave it to DT experts, but I was under the impression that we > should be using generic functionality names (usb, i2c, spi, uart, gpio, > etc) instead of the IP name. IP name is something more for compatible > flag. > > Don't take my word for it though :-) DT experts are the ones with final > saying Wrt node name, as far as I am aware of, there is no strict convention of naming nodes, but the way you suggested is better in terms of readability - you don't have to know this particular IP to find out what it is used for. Similar thing is with @addr in node names. I've been always adding @addr to the name whenever the node had reg property inside (with the same address of course), but I'm not sure if there is a strict convention here. Best regards, Tomasz Figa ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver 2012-11-07 17:18 ` Tomasz Figa @ 2012-11-08 5:06 ` Vivek Gautam 0 siblings, 0 replies; 7+ messages in thread From: Vivek Gautam @ 2012-11-08 5:06 UTC (permalink / raw) To: Tomasz Figa Cc: balbi, Vivek Gautam, linux-samsung-soc, devicetree-discuss, linux-usb, kgene.kim, av.tikhomirov, yulgon.kim, Thomas Abraham, Praveen Paneri Hi, On Wed, Nov 7, 2012 at 10:48 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Vivek, Felipe, > > On Wednesday 07 of November 2012 18:43:22 Felipe Balbi wrote: >> Hi, >> >> On Wed, Nov 07, 2012 at 06:55:03PM +0530, Vivek Gautam wrote: >> > Hi, >> > >> > On Tue, Nov 6, 2012 at 10:13 PM, Felipe Balbi <balbi@ti.com> wrote: >> > > On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: >> > >> Adding DWC3 device tree node for Exynos5250 along with the >> > >> device address and clock support needed for the controller. >> > >> >> > >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> >> > >> --- >> > >> >> > >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ >> > >> arch/arm/mach-exynos/clock-exynos5.c | 24 >> > >> ++++++++++++++++++++++++ >> > >> arch/arm/mach-exynos/include/mach/map.h | 1 + >> > >> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ >> > >> drivers/usb/Kconfig | 1 + >> > >> 5 files changed, 34 insertions(+), 0 deletions(-) >> > >> >> > >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi >> > >> b/arch/arm/boot/dts/exynos5250.dtsi index cf6a02d..52bca54 100644 >> > >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> > >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> > >> @@ -68,6 +68,12 @@ >> > >> >> > >> interrupts = <0 96 0>; >> > >> >> > >> }; >> > >> >> > >> + dwc3 { >> > > >> > > shouldn't this be usb@12000000 ?? >> > >> > Kept this in accordance with controller's name, similar to the change >> > in following: >> > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg12800. >> > html >> > >> > Needs to be changed ? >> >> I'll leave it to DT experts, but I was under the impression that we >> should be using generic functionality names (usb, i2c, spi, uart, gpio, >> etc) instead of the IP name. IP name is something more for compatible >> flag. >> >> Don't take my word for it though :-) DT experts are the ones with final >> saying > > Wrt node name, as far as I am aware of, there is no strict convention of > naming nodes, but the way you suggested is better in terms of readability - > you don't have to know this particular IP to find out what it is used for. > > Similar thing is with @addr in node names. I've been always adding @addr to > the name whenever the node had reg property inside (with the same address > of course), but I'm not sure if there is a strict convention here. > Better to make things more readable ;-) It will be nice that i change this to dwc3 as well as ehci and ohci in the change: http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg12800. Thanks for suggestions. I shall also update the Documentation/devicetree/bindings. I missed that here :-( > Best regards, > Tomasz Figa > -- Thanks & Regards Vivek ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-11-08 5:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-06 15:28 [PATCH] ARM: EXYNOS5250: Add support for USB 3.0 dwc3 controller Vivek Gautam
2012-11-06 15:28 ` [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver Vivek Gautam
2012-11-06 16:43 ` Felipe Balbi
[not found] ` <20121106164304.GD3993-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-07 13:25 ` Vivek Gautam
[not found] ` <CAFp+6iGFwTAvhamhoQszBL8QUau64XtDWGR1yX0azbuw1iWgVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-07 16:43 ` Felipe Balbi
2012-11-07 17:18 ` Tomasz Figa
2012-11-08 5:06 ` Vivek Gautam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).