From: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e
Date: Wed, 7 Nov 2012 10:29:20 +1100 [thread overview]
Message-ID: <20121106232920.GL23553@truffula.fritz.box> (raw)
In-Reply-To: <1352224831-1355-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Tue, Nov 06, 2012 at 11:00:31AM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Not all /bin/echo implementations support the -e option. Instead, use
> printf, which appears to be more widely available than /bin/echo -e.
>
> See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
> bash" for history.
>
> I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
> and bash.
>
> Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Mike, should I re-write this with you as the git author? If so, could
> you please supply an S-o-b line for this?
> ---
> tests/fdtget-runtest.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
> index c3a3559..8d8b058 100755
> --- a/tests/fdtget-runtest.sh
> +++ b/tests/fdtget-runtest.sh
> @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
> trap "rm -f $LOG $EXPECT" 0
>
> expect="$1"
> -/bin/echo -e $expect >$EXPECT
> +printf '%b\n' "$expect" > $EXPECT
Um.. this is made to apply on top of the /bin/echo patch, but AFAICT
that was never committed..
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-11-06 23:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 18:00 [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e Stephen Warren
[not found] ` <1352224831-1355-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-06 23:29 ` David Gibson [this message]
[not found] ` <20121106232920.GL23553-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-11-07 0:26 ` Stephen Warren
[not found] ` <5099AAA1.8090903-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-07 0:53 ` David Gibson
[not found] ` <20121107005338.GN23553-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-11-07 2:27 ` Stephen Warren
[not found] ` <5099C70F.5040801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-07 2:42 ` David Gibson
[not found] ` <20121107024206.GP23553-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-11-10 0:54 ` Mike Frysinger
2012-11-10 0:53 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106232920.GL23553@truffula.fritz.box \
--to=david-xt8fgy+axnrb3ne2bgzf6laj5h9x9tb+@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).