[PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[Stephen Warren]

From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Not all /bin/echo implementations support the -e option. Instead, use
printf, which appears to be more widely available than /bin/echo -e.

See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
bash" for history.

I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
and bash.

Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by
Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Mike, should I re-write this with you as the git author? If so, could
you please supply an S-o-b line for this?
---
 tests/fdtget-runtest.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
index c3a3559..8d8b058 100755
--- a/tests/fdtget-runtest.sh
+++ b/tests/fdtget-runtest.sh
@@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
 trap "rm -f $LOG $EXPECT" 0
 
 expect="$1"
-/bin/echo -e $expect >$EXPECT
+printf '%b\n' "$expect" > $EXPECT
 shift
 
 verbose_run_log_check "$LOG" $VALGRIND $DTGET "$@"
-- 
1.7.0.4

Re: [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[David Gibson]

On Tue, Nov 06, 2012 at 11:00:31AM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Not all /bin/echo implementations support the -e option. Instead, use
> printf, which appears to be more widely available than /bin/echo -e.
> 
> See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
> bash" for history.
> 
> I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
> and bash.
> 
> Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Mike, should I re-write this with you as the git author? If so, could
> you please supply an S-o-b line for this?
> ---
>  tests/fdtget-runtest.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
> index c3a3559..8d8b058 100755
> --- a/tests/fdtget-runtest.sh
> +++ b/tests/fdtget-runtest.sh
> @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
>  trap "rm -f $LOG $EXPECT" 0
>  
>  expect="$1"
> -/bin/echo -e $expect >$EXPECT
> +printf '%b\n' "$expect" > $EXPECT

Um.. this is made to apply on top of the /bin/echo patch, but AFAICT
that was never committed..

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[Stephen Warren]

On 11/06/2012 04:29 PM, David Gibson wrote:
> On Tue, Nov 06, 2012 at 11:00:31AM -0700, Stephen Warren wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> Not all /bin/echo implementations support the -e option. Instead, use
>> printf, which appears to be more widely available than /bin/echo -e.
>>
>> See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
>> bash" for history.
>>
>> I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
>> and bash.
>>
>> Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by
>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> Mike, should I re-write this with you as the git author? If so, could
>> you please supply an S-o-b line for this?
>> ---
>>  tests/fdtget-runtest.sh |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
>> index c3a3559..8d8b058 100755
>> --- a/tests/fdtget-runtest.sh
>> +++ b/tests/fdtget-runtest.sh
>> @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
>>  trap "rm -f $LOG $EXPECT" 0
>>  
>>  expect="$1"
>> -/bin/echo -e $expect >$EXPECT
>> +printf '%b\n' "$expect" > $EXPECT
> 
> Um.. this is made to apply on top of the /bin/echo patch, but AFAICT
> that was never committed..

I believe it's commit eaec1db "fdtget-runtest.sh: Fix failures when
/bin/sh isn't bash"; my local git certainly shows Jon as the committer
for that change.

Re: [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[David Gibson]

On Tue, Nov 06, 2012 at 05:26:09PM -0700, Stephen Warren wrote:
> On 11/06/2012 04:29 PM, David Gibson wrote:
> > On Tue, Nov 06, 2012 at 11:00:31AM -0700, Stephen Warren wrote:
> >> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >>
> >> Not all /bin/echo implementations support the -e option. Instead, use
> >> printf, which appears to be more widely available than /bin/echo -e.
> >>
> >> See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
> >> bash" for history.
> >>
> >> I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
> >> and bash.
> >>
> >> Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by
> >> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >> ---
> >> Mike, should I re-write this with you as the git author? If so, could
> >> you please supply an S-o-b line for this?
> >> ---
> >>  tests/fdtget-runtest.sh |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
> >> index c3a3559..8d8b058 100755
> >> --- a/tests/fdtget-runtest.sh
> >> +++ b/tests/fdtget-runtest.sh
> >> @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
> >>  trap "rm -f $LOG $EXPECT" 0
> >>  
> >>  expect="$1"
> >> -/bin/echo -e $expect >$EXPECT
> >> +printf '%b\n' "$expect" > $EXPECT
> > 
> > Um.. this is made to apply on top of the /bin/echo patch, but AFAICT
> > that was never committed..
> 
> I believe it's commit eaec1db "fdtget-runtest.sh: Fix failures when
> /bin/sh isn't bash"; my local git certainly shows Jon as the committer
> for that change.

I just pulled from git.jdl.com and I don't see anything after
e4b497f367a3b2ae99cc52089a14a221b13a76ef, which was on Oct 16.

???

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[Stephen Warren]

On 11/06/2012 05:53 PM, David Gibson wrote:
> On Tue, Nov 06, 2012 at 05:26:09PM -0700, Stephen Warren wrote:
>> On 11/06/2012 04:29 PM, David Gibson wrote:
>>> On Tue, Nov 06, 2012 at 11:00:31AM -0700, Stephen Warren wrote:
>>>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>>>
>>>> Not all /bin/echo implementations support the -e option. Instead, use
>>>> printf, which appears to be more widely available than /bin/echo -e.
>>>>
>>>> See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
>>>> bash" for history.
>>>>
>>>> I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
>>>> and bash.
>>>>
>>>> Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by
>>>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>>> ---
>>>> Mike, should I re-write this with you as the git author? If so, could
>>>> you please supply an S-o-b line for this?
>>>> ---
>>>>  tests/fdtget-runtest.sh |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
>>>> index c3a3559..8d8b058 100755
>>>> --- a/tests/fdtget-runtest.sh
>>>> +++ b/tests/fdtget-runtest.sh
>>>> @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
>>>>  trap "rm -f $LOG $EXPECT" 0
>>>>  
>>>>  expect="$1"
>>>> -/bin/echo -e $expect >$EXPECT
>>>> +printf '%b\n' "$expect" > $EXPECT
>>>
>>> Um.. this is made to apply on top of the /bin/echo patch, but AFAICT
>>> that was never committed..
>>
>> I believe it's commit eaec1db "fdtget-runtest.sh: Fix failures when
>> /bin/sh isn't bash"; my local git certainly shows Jon as the committer
>> for that change.
> 
> I just pulled from git.jdl.com and I don't see anything after
> e4b497f367a3b2ae99cc52089a14a221b13a76ef, which was on Oct 16.

Yes, Oct 16 is the last commit date I see too, but the patch was
committed long before that:

> commit eaec1dbc5946d5fd01a9ef7120f8461c74d759a0
> Author:     Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> AuthorDate: Tue Mar 20 20:23:46 2012 -0600
> Commit:     Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>
> CommitDate: Sat Mar 31 09:00:29 2012 -0500
> 
>     fdtget-runtest.sh: Fix failures when /bin/sh isn't bash
>     
>     On Ubuntu, /bin/sh is dash (at least by default), and dash's echo doesn't
>     accept the -e option. This means that fdtget-runtest.sh's EXPECT file will
>     contain "-e foo" rather than just "foo", which causes a test failure.
>     
>     To work around this, run /bin/echo instead of (builtin) echo, which has
>     more chance of supporting the -e option.
>     
>     Another possible fix is to change all the #! lines to /bin/bash rather
>     than /bin/sh, and change run_tests.sh to invoke sub-scripts using $SHELL
>     instead of just "sh". However, that would require bash specifically, which
>     may not be desirable.
>     
>     Signed-off-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
>     Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>

Re: [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[David Gibson]

On Tue, Nov 06, 2012 at 07:27:27PM -0700, Stephen Warren wrote:
> On 11/06/2012 05:53 PM, David Gibson wrote:
> > On Tue, Nov 06, 2012 at 05:26:09PM -0700, Stephen Warren wrote:
> >> On 11/06/2012 04:29 PM, David Gibson wrote:
> >>> On Tue, Nov 06, 2012 at 11:00:31AM -0700, Stephen Warren wrote:
> >>>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >>>>
> >>>> Not all /bin/echo implementations support the -e option. Instead, use
> >>>> printf, which appears to be more widely available than /bin/echo -e.
> >>>>
> >>>> See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
> >>>> bash" for history.
> >>>>
> >>>> I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
> >>>> and bash.
> >>>>
> >>>> Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by
> >>>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >>>> ---
> >>>> Mike, should I re-write this with you as the git author? If so, could
> >>>> you please supply an S-o-b line for this?
> >>>> ---
> >>>>  tests/fdtget-runtest.sh |    2 +-
> >>>>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>>>
> >>>> diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
> >>>> index c3a3559..8d8b058 100755
> >>>> --- a/tests/fdtget-runtest.sh
> >>>> +++ b/tests/fdtget-runtest.sh
> >>>> @@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
> >>>>  trap "rm -f $LOG $EXPECT" 0
> >>>>  
> >>>>  expect="$1"
> >>>> -/bin/echo -e $expect >$EXPECT
> >>>> +printf '%b\n' "$expect" > $EXPECT
> >>>
> >>> Um.. this is made to apply on top of the /bin/echo patch, but AFAICT
> >>> that was never committed..
> >>
> >> I believe it's commit eaec1db "fdtget-runtest.sh: Fix failures when
> >> /bin/sh isn't bash"; my local git certainly shows Jon as the committer
> >> for that change.
> > 
> > I just pulled from git.jdl.com and I don't see anything after
> > e4b497f367a3b2ae99cc52089a14a221b13a76ef, which was on Oct 16.
> 
> Yes, Oct 16 is the last commit date I see too, but the patch was
> committed long before that:

Ah, so it was.  I didn't realise there had been such a long delay
between the initial patch and this discussion.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 148 bytes --]

On Tuesday 06 November 2012 13:00:31 Stephen Warren wrote:
> Mike, should I re-write this with you as the git author?


nah, you did the work
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e

[Mike Frysinger]

[-- Attachment #1.1: Type: Text/Plain, Size: 249 bytes --]

On Tuesday 06 November 2012 21:42:06 David Gibson wrote:
> Ah, so it was.  I didn't realise there had been such a long delay
> between the initial patch and this discussion.

yes, i was perusing my backlog on the list when i came across it ;)
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss