From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Qing Xu <qingx@marvell.com>
Cc: lrg@ti.com, sameo@linux.intel.com, grant.likely@secretlab.ca,
rob.herring@calxeda.com, haojian.zhuang@gmail.com,
cxie4@marvell.com, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v4 5/7] mfd: max8925: support dt for regulator
Date: Wed, 7 Nov 2012 15:20:08 +0100 [thread overview]
Message-ID: <20121107142007.GB20844@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352282993-26449-1-git-send-email-qingx@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Wed, Nov 07, 2012 at 06:09:53PM +0800, Qing Xu wrote:
> From: Qing Xu <qingx@marvell.com>
>
> Signed-off-by: Qing Xu <qingx@marvell.com>
Applied, thanks.
> +max8925 regulator device register is still handled by mfd_add_devices, not by
> +of_xxx, so, it is not necessary to add compatible name. Also, those reg
> +offset and id info is stored in mfd_cell(see max8925-core.c), as a result
> +there is not private properties in dts.
> +node's name should match with the definition in max8925_regulator_matches
> +(see max8925-regulator.c)
Please submit a followup which removes all the Linux-specific references
and just enumerates the supported regulators. Please do also use a
subject line appropriate for the subsystem - this is for the regulator
driver so it should be regulator:
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-07 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 10:09 [PATCH v4 5/7] mfd: max8925: support dt for regulator Qing Xu
2012-11-07 14:20 ` Mark Brown [this message]
2012-11-08 2:32 ` Qing Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121107142007.GB20844@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cxie4@marvell.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=haojian.zhuang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=qingx@marvell.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).