devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e
@ 2012-11-06 18:00 Stephen Warren
       [not found] ` <1352224831-1355-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
  0 siblings, 1 reply; 8+ messages in thread
From: Stephen Warren @ 2012-11-06 18:00 UTC (permalink / raw)
  To: David Gibson, jdl-CYoMK+44s/E, Mike Frysinger
  Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Stephen Warren

From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Not all /bin/echo implementations support the -e option. Instead, use
printf, which appears to be more widely available than /bin/echo -e.

See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't
bash" for history.

I have tested this on Ubuntu 10.04 with /bin/sh pointing to both dash
and bash.

Reported-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org> # and implemented-by
Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Mike, should I re-write this with you as the git author? If so, could
you please supply an S-o-b line for this?
---
 tests/fdtget-runtest.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
index c3a3559..8d8b058 100755
--- a/tests/fdtget-runtest.sh
+++ b/tests/fdtget-runtest.sh
@@ -8,7 +8,7 @@ rm -f $LOG $EXPECT
 trap "rm -f $LOG $EXPECT" 0
 
 expect="$1"
-/bin/echo -e $expect >$EXPECT
+printf '%b\n' "$expect" > $EXPECT
 shift
 
 verbose_run_log_check "$LOG" $VALGRIND $DTGET "$@"
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-11-10  0:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-06 18:00 [PATCH] fdtget-runtest.sh: use printf instead of /bin/echo -e Stephen Warren
     [not found] ` <1352224831-1355-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-06 23:29   ` David Gibson
     [not found]     ` <20121106232920.GL23553-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-11-07  0:26       ` Stephen Warren
     [not found]         ` <5099AAA1.8090903-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-07  0:53           ` David Gibson
     [not found]             ` <20121107005338.GN23553-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-11-07  2:27               ` Stephen Warren
     [not found]                 ` <5099C70F.5040801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-07  2:42                   ` David Gibson
     [not found]                     ` <20121107024206.GP23553-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2012-11-10  0:54                       ` Mike Frysinger
2012-11-10  0:53   ` Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).