From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/3] gpio: Add simple poweroff-gpio driver Date: Mon, 12 Nov 2012 07:07:40 +0100 Message-ID: <20121112060740.GR24583@lunn.ch> References: <1352650891-18356-1-git-send-email-andrew@lunn.ch> <1352650891-18356-2-git-send-email-andrew@lunn.ch> <20121112011258.GA23724@lizard> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20121112011258.GA23724@lizard> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Anton Vorontsov Cc: Andrew Lunn , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, gmbnomis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, Nov 11, 2012 at 05:12:58PM -0800, Anton Vorontsov wrote: > On Mon, Nov 12, 2012 at 02:00:31AM +0100, Linus Walleij wrote: > > On Sun, Nov 11, 2012 at 5:21 PM, Andrew Lunn wrote: > > > > > From: Jamie Lentin > > > > > > Given appropriate devicetree bindings, this driver registers a > > > pm_power_off function to set a GPIO line high/low to power down > > > your board. > > > > > > Signed-off-by: Jamie Lentin > > > Signed-off-by: Andrew Lunn > > > > So this is just a GPIO client like any such thing right? > > > > I mean this thing has nothing more to do with the GPIO subsystem > > than say, drivers/input/keyboard/gpio_keys.c? > > > > So from the GPIO subsystem point of view controlling power is > > an alien concept. > > > > But I suspect Anton may be ready to welcome a driver like this > > under drivers/power/* which I think is where it belongs. > > Yup. driver/power/reset/ seems appropriate. Hi Anton I was unsure where to put it. I will submit new patches with the move. I'm not too sure about 'reset' though. Its not a reset operation, the power goes off and stays off. Would 'shutdown' or 'power_off' be better? Andrew