From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] drivers/of: Constify device_node->name and ->path_component_name Date: Wed, 14 Nov 2012 17:49:38 -0500 (EST) Message-ID: <20121114.174938.1893866220809474233.davem@davemloft.net> References: <1352932107-14782-1-git-send-email-grant.likely@secretlab.ca> <20121114.173304.405703188822325414.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: sparclinux-owner@vger.kernel.org To: grant.likely@secretlab.ca Cc: linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org, benh@kernel.crashing.org List-Id: devicetree@vger.kernel.org From: Grant Likely Date: Wed, 14 Nov 2012 22:42:26 +0000 > On Wed, Nov 14, 2012 at 10:33 PM, David Miller wrote: >> >> You're making other changes here, such as the kstrdup() stuff, >> seperate that into another patch. > > It's part of the same change. The original code was allocating a > buffer, saving the pointer in the name field and then modifying it. > Making the code to a kstrdup() gets rid of modifying the const buffer. Please mention that in your commit message then, thanks.