From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 6/7] ARM: dove: switch to DT clock providers Date: Thu, 15 Nov 2012 22:52:23 +0100 Message-ID: <20121115225223.1ceebfe5@skate> References: <1353014906-31566-1-git-send-email-andrew@lunn.ch> <1353014906-31566-7-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1353014906-31566-7-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Andrew Lunn Cc: mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux ARM , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Dear Andrew Lunn, On Thu, 15 Nov 2012 22:28:25 +0100, Andrew Lunn wrote: > + core_clk: core-clocks@d0214 { > + compatible = "marvell,dove-core-clocks"; > + reg = <0xd0214 0x4>; > + #clock-cells = <1>; > + }; > + > + clk_gate: clock-gating-control@d0038 { > + compatible = "marvell,dove-clock-gating"; > + reg = <0xd0038 0x4>; > + clocks = <&core_clk 0>; > + #clock-cells = <1>; > + }; I'm nitpicking maybe, but names lack a bit of coherency here: core_clk vs. clk_gate marvell,dove-core-clocks vs. marvell,dove-clock-gating Maybe: core_clk / gate_clk marvell,dove-core-clocks / marvell,dove-gating-clocks Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com