From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] drivers/of: Constify device_node->name and ->path_component_name Date: Fri, 16 Nov 2012 12:33:58 -0500 (EST) Message-ID: <20121116.123358.444599559940168490.davem@davemloft.net> References: <1353075625-7755-1-git-send-email-grant.likely@secretlab.ca> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1353075625-7755-1-git-send-email-grant.likely@secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org To: grant.likely@secretlab.ca Cc: linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org, benh@kernel.crashing.org, julian.calaby@gmail.com List-Id: devicetree@vger.kernel.org From: Grant Likely Date: Fri, 16 Nov 2012 14:20:25 +0000 > Neither of these should ever be changed once set. Make them const and > fix up the users that try to modify it in-place. In one case > kmalloc+memcpy is replaced with kstrdup() to avoid modifying the string. > > Build tested with defconfigs on ARM, PowerPC, Sparc, MIPS, x86 among > others. > > Signed-off-by: Grant Likely Acked-by: David S. Miller