From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 1/9] usb: chipidea: pci: mark platformdata as static and __devinitdata Date: Fri, 16 Nov 2012 04:02:34 -0800 Message-ID: <20121116120234.GA13498@kroah.com> References: <1352909950-32555-1-git-send-email-m.grzeschik@pengutronix.de> <1352909950-32555-2-git-send-email-m.grzeschik@pengutronix.de> <87haop7tfi.fsf@ashishki-desk.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87haop7tfi.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Shishkin Cc: Michael Grzeschik , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Nov 16, 2012 at 12:06:57PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > From: Marc Kleine-Budde > > > > Signed-off-by: Marc Kleine-Budde > > Signed-off-by: Michael Grzeschik > > static yes, __devinitdata -- probably not. These structs are used > everywhere throughout the driver currently, not only at initialization > time. __devinitdata means nothing anymore given that CONFIG_HOTPLUG is always enabled. It also will probably be removed for 3.8, so don't even worry about adding these types of markings to variables. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html