From: David Miller <davem@davemloft.net>
To: andreas@gaisler.com
Cc: sam@ravnborg.org, rob.herring@calxeda.com,
grant.likely@secretlab.ca, sparclinux@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH] of/address: sparc: Declare of_iomap as an extern function for sparc again
Date: Fri, 23 Nov 2012 14:21:10 -0500 (EST) [thread overview]
Message-ID: <20121123.142110.835354734152648777.davem@davemloft.net> (raw)
In-Reply-To: <1353669849-23697-1-git-send-email-andreas@gaisler.com>
From: Andreas Larsson <andreas@gaisler.com>
Date: Fri, 23 Nov 2012 12:24:09 +0100
> This bug-fix makes sure that of_iomap is defined extern for sparc so that the
> sparc-specific implementation of_iomap is once again used when including
> include/linux/of_address.h in a sparc context. OF_GPIO that is now available for
> sparc relies on this.
>
> The bug was inadvertently introduced in a850a75, "of/address: add empty static
> inlines for !CONFIG_OF", that added a static dummy inline for of_iomap when
> !CONFIG_OF_ADDRESS. However, CONFIG_OF_ADDRESS is never defined for sparc, but
> there is a sparc-specific implementation /arch/sparc/kernel/of_device_common.c.
>
> This fix takes the same approach as 0bce04b that solved the equivalent problem
> for of_address_to_resource.
>
> Signed-off-by: Andreas Larsson <andreas@gaisler.com>
Grant, can you possibly merge this to Linus while I'm travelling?
That would help me a lot.
Thanks!
next prev parent reply other threads:[~2012-11-23 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 11:24 [PATCH] of/address: sparc: Declare of_iomap as an extern function for sparc again Andreas Larsson
2012-11-23 19:21 ` David Miller [this message]
2012-11-23 21:59 ` Grant Likely
2012-11-23 23:34 ` Grant Likely
2012-11-23 23:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123.142110.835354734152648777.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreas@gaisler.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sam@ravnborg.org \
--cc=software@gaisler.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).