devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: "Philip, Avinash" <avinashphilip-l0cyMroinI0@public.gmane.org>
Cc: "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"Nori, Sekhar" <nsekhar-l0cyMroinI0@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Hebbar, Gururaja" <gururaja.hebbar-l0cyMroinI0@public.gmane.org>,
	"Bedia, Vaibhav" <vaibhav.bedia-l0cyMroinI0@public.gmane.org>,
	"linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support
Date: Fri, 23 Nov 2012 11:51:10 +0100	[thread overview]
Message-ID: <20121123105110.GA6884@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <518397C60809E147AF5323E0420B992E3E9EE991-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 929 bytes --]

On Fri, Nov 23, 2012 at 10:34:02AM +0000, Philip, Avinash wrote:
> On Fri, Nov 23, 2012 at 02:29:44, Thierry Reding wrote:
> > On Wed, Nov 21, 2012 at 06:41:02PM +0530, Philip, Avinash wrote:
> > [...]
> > > +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> > > +	if (IS_ERR(pinctrl))
> > > +		dev_warn(&pdev->dev, "failed to configure pins from driver\n");
> > 
> > I think we already discussed this, but shouldn't this be a fatal error?
> 
> I had checked relevant discussion and found this can be warning message.
> This is because most boards don't have pinctrl implemented at this point,
> or may never have.
> 
> https://lkml.org/lkml/2012/9/11/369
> 
> Any way I will change to
> dev_warn(&pdev->dev, "unable to select pin group\n");
> as in other drivers.

But in case pinctrl isn't implemented, shouldn't the implementation of
devm_pinctrl_get_select_default() just be a no-op?

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

  parent reply	other threads:[~2012-11-23 10:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21 13:10 [PATCH v4 00/11] Support for AM33xx PWM Subsystem Philip, Avinash
2012-11-21 13:10 ` [PATCH v4 01/11] PWMSS: Add PWM Subsystem driver for parent<->child relationship Philip, Avinash
2012-11-22 20:47   ` Thierry Reding
2012-11-23 10:34     ` Philip, Avinash
2012-11-21 13:10 ` [PATCH v4 02/11] ARM: am33xx: clk: Add optional clock for EHRPWM Philip, Avinash
     [not found] ` <1353503469-18634-1-git-send-email-avinashphilip-l0cyMroinI0@public.gmane.org>
2012-11-21 13:11   ` [PATCH v4 03/11] ARM: OMAP: AM33xx hwmod: Add parent-child relationship for PWM subsystem Philip, Avinash
2012-11-21 13:11   ` [PATCH v4 04/11] pwm: pwm-tiecap: Add device-tree binding support for APWM driver Philip, Avinash
2012-11-22 20:57     ` Thierry Reding
2012-11-23 10:34       ` Philip, Avinash
     [not found]     ` <1353503469-18634-5-git-send-email-avinashphilip-l0cyMroinI0@public.gmane.org>
2012-11-22 21:46       ` Thierry Reding
2012-11-21 13:11   ` [PATCH v4 05/11] pwm: pwm-tiecap: pinctrl support Philip, Avinash
     [not found]     ` <1353503469-18634-6-git-send-email-avinashphilip-l0cyMroinI0@public.gmane.org>
2012-11-22 20:59       ` Thierry Reding
2012-11-23 10:34         ` Philip, Avinash
     [not found]           ` <518397C60809E147AF5323E0420B992E3E9EE991-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-11-23 10:51             ` Thierry Reding [this message]
2012-11-23 11:12               ` Philip, Avinash
2012-11-23 11:18                 ` Thierry Reding
2012-11-23 12:48                   ` Peter Korsgaard
     [not found]                     ` <87mwy8eb7w.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
2012-11-24 20:34                       ` Thierry Reding
2012-11-27 14:20                         ` Peter Korsgaard
2012-11-22 21:06       ` Thierry Reding
2012-11-21 13:11   ` [PATCH v4 07/11] pwm: pwm-tiehrpwm: " Philip, Avinash
2012-11-22 21:04     ` Thierry Reding
2012-11-22 21:16   ` [PATCH v4 00/11] Support for AM33xx PWM Subsystem Thierry Reding
2012-11-23 10:42     ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 06/11] pwm: pwm-tiehrpwm: Add device-tree binding support for EHRPWM driver Philip, Avinash
     [not found]   ` <1353503469-18634-7-git-send-email-avinashphilip-l0cyMroinI0@public.gmane.org>
2012-11-22 21:03     ` Thierry Reding
     [not found]       ` <20121122210347.GD16716-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-11-23 10:35         ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 08/11] pwm: pwm-tiehrpwm: Adding TBCLK gating support Philip, Avinash
2012-11-22 21:05   ` Thierry Reding
2012-11-21 13:11 ` [PATCH v4 09/11] ARM: dts: AM33XX: Add PWMSS device tree nodes Philip, Avinash
     [not found]   ` <1353503469-18634-10-git-send-email-avinashphilip-l0cyMroinI0@public.gmane.org>
2012-11-22 21:08     ` Thierry Reding
     [not found]       ` <20121122210857.GH16716-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-11-23 10:35         ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 10/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evm Philip, Avinash
     [not found]   ` <1353503469-18634-11-git-send-email-avinashphilip-l0cyMroinI0@public.gmane.org>
2012-11-22 21:11     ` Thierry Reding
2012-11-23 10:35       ` Philip, Avinash
2012-11-21 13:11 ` [PATCH v4 11/11] ARM: dts: AM33XX: Add PWM backlight DT data to am335x-evmsk Philip, Avinash
2012-11-22 21:12   ` Thierry Reding
     [not found]     ` <20121122211245.GJ16716-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-11-23 10:35       ` Philip, Avinash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121123105110.GA6884@avionic-0098.adnet.avionic-design.de \
    --to=thierry.reding-rm9k5ik7kjkj5m59nbduvrnah6klmebb@public.gmane.org \
    --cc=avinashphilip-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=gururaja.hebbar-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    --cc=vaibhav.bedia-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).