From: Lee Jones <lee.jones@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linus.walleij@linaro.org, grant.likely@secretlab.ca,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, spear-devel@list.st.com,
Vipul Kumar Samar <vipulkumar.samar@st.com>
Subject: Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio
Date: Fri, 23 Nov 2012 12:14:13 +0000 [thread overview]
Message-ID: <20121123121413.GB22268@gmail.com> (raw)
In-Reply-To: <CAKohponW-Wd+Vrnj8mbdFMmJvwQgPq1jFCZRipBFoEhTknStHQ@mail.gmail.com>
> >> - stmpe_gpio->chip.base = pdata ? pdata->gpio_base : -1;
> >
> > Why have you deleted this?
> >
> >> +
> >> + if (pdata) {
> >> + stmpe_gpio->norequest_mask = pdata->norequest_mask;
> >> + stmpe_gpio->chip.base = pdata->gpio_base;
> >
> > Then added this?
> >
> >> + } else {
> >> + stmpe_gpio->chip.base = -1;
> >
> > And this?
>
> To group all non-DT assignments in a single if block, instead of two.
That assignment has nothing to do with DT.
> > Just leave the top line in and it saves you lots of complecations.
>
> Sorry, Couldn't get this one.
I'm saying, just leave it where it is.
> >> + if (np)
> >> + of_property_read_u32(np, "st,norequest-mask",
> >> + &pdata->norequest_mask);
> >
> > Can you explain to me what this does?
>
> You mean pdata->norequest_mask? It marks few gpios as unusable.
> Because these pads might be used by other blocks of stmpe.
I'm not sure if that should be set with DT or not.
Second opinion anyone?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-23 12:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 5:51 [PATCH] gpio: stmpe: Add DT support for stmpe gpio Viresh Kumar
2012-11-23 10:34 ` Lee Jones
2012-11-23 10:41 ` Lee Jones
[not found] ` <20121123104140.GP17471-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-23 10:47 ` Viresh Kumar
2012-11-23 10:43 ` Viresh Kumar
2012-11-23 12:14 ` Lee Jones [this message]
[not found] ` <20121123121413.GB22268-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-23 12:25 ` Viresh Kumar
2012-11-23 15:45 ` Lee Jones
2012-11-23 12:30 ` Shiraz Hashim
2012-11-26 11:28 ` Lee Jones
2012-11-26 11:32 ` Shiraz Hashim
2012-12-01 16:35 ` Linus Walleij
2012-12-01 18:31 ` Shiraz Hashim
2012-12-01 19:34 ` Linus Walleij
[not found] ` <CACRpkda6=UPW+Xy9ztkAtFvCMySt4iR8YabYNNTdnZBpVc98rQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-01 19:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123121413.GB22268@gmail.com \
--to=lee.jones@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).