From: Shiraz Hashim <shiraz.hashim@st.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linus.walleij@linaro.org, Viresh Kumar <viresh.kumar@linaro.org>,
grant.likely@secretlab.ca, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, spear-devel@list.st.com,
Vipul Kumar Samar <vipulkumar.samar@st.com>
Subject: Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio
Date: Mon, 26 Nov 2012 17:02:30 +0530 [thread overview]
Message-ID: <20121126113230.GT5384@localhost.localdomain> (raw)
In-Reply-To: <20121126112823.GI12782@gmail.com>
On Mon, Nov 26, 2012 at 11:28:23AM +0000, Lee Jones wrote:
> On Fri, 23 Nov 2012, Shiraz Hashim wrote:
>
> > On Fri, Nov 23, 2012 at 12:14:13PM +0000, Lee Jones wrote:
> > > > >> + if (np)
> > > > >> + of_property_read_u32(np, "st,norequest-mask",
> > > > >> + &pdata->norequest_mask);
> > > > >
> > > > > Can you explain to me what this does?
> > > >
> > > > You mean pdata->norequest_mask? It marks few gpios as unusable.
> > > > Because these pads might be used by other blocks of stmpe.
> > >
> > > I'm not sure if that should be set with DT or not.
> > >
> > > Second opinion anyone?
> >
> > This is a board dependent parameter which just informs gpio driver
> > about pins, which must not be requested. It may happen for a stmpe
> > variant where such gpio pins are multiplexed with some other
> > function.
> >
> > Hence it must be part of DT itself.
>
> Doesn't pinctrl normally handle this kind of stuff?
Yes, but I think it is only for managing the SoC and its pads.
--
regards
Shiraz
next prev parent reply other threads:[~2012-11-26 11:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 5:51 [PATCH] gpio: stmpe: Add DT support for stmpe gpio Viresh Kumar
2012-11-23 10:34 ` Lee Jones
2012-11-23 10:41 ` Lee Jones
[not found] ` <20121123104140.GP17471-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-23 10:47 ` Viresh Kumar
2012-11-23 10:43 ` Viresh Kumar
2012-11-23 12:14 ` Lee Jones
[not found] ` <20121123121413.GB22268-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-23 12:25 ` Viresh Kumar
2012-11-23 15:45 ` Lee Jones
2012-11-23 12:30 ` Shiraz Hashim
2012-11-26 11:28 ` Lee Jones
2012-11-26 11:32 ` Shiraz Hashim [this message]
2012-12-01 16:35 ` Linus Walleij
2012-12-01 18:31 ` Shiraz Hashim
2012-12-01 19:34 ` Linus Walleij
[not found] ` <CACRpkda6=UPW+Xy9ztkAtFvCMySt4iR8YabYNNTdnZBpVc98rQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-01 19:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126113230.GT5384@localhost.localdomain \
--to=shiraz.hashim@st.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).