From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shiraz Hashim Subject: Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio Date: Mon, 26 Nov 2012 17:02:30 +0530 Message-ID: <20121126113230.GT5384@localhost.localdomain> References: <912d88b8906ce87cf5459cf3d5798e03bfce34c7.1353649737.git.viresh.kumar@linaro.org> <20121123103400.GO17471@gmail.com> <20121123121413.GB22268@gmail.com> <20121123123048.GM5384@localhost.localdomain> <20121126112823.GI12782@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20121126112823.GI12782@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones Cc: linus.walleij@linaro.org, Viresh Kumar , grant.likely@secretlab.ca, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, Vipul Kumar Samar List-Id: devicetree@vger.kernel.org On Mon, Nov 26, 2012 at 11:28:23AM +0000, Lee Jones wrote: > On Fri, 23 Nov 2012, Shiraz Hashim wrote: > > > On Fri, Nov 23, 2012 at 12:14:13PM +0000, Lee Jones wrote: > > > > >> + if (np) > > > > >> + of_property_read_u32(np, "st,norequest-mask", > > > > >> + &pdata->norequest_mask); > > > > > > > > > > Can you explain to me what this does? > > > > > > > > You mean pdata->norequest_mask? It marks few gpios as unusable. > > > > Because these pads might be used by other blocks of stmpe. > > > > > > I'm not sure if that should be set with DT or not. > > > > > > Second opinion anyone? > > > > This is a board dependent parameter which just informs gpio driver > > about pins, which must not be requested. It may happen for a stmpe > > variant where such gpio pins are multiplexed with some other > > function. > > > > Hence it must be part of DT itself. > > Doesn't pinctrl normally handle this kind of stuff? Yes, but I think it is only for managing the SoC and its pads. -- regards Shiraz