From: Grant Likely <grant.likely@secretlab.ca>
To: Michael Neuling <mikey@neuling.org>
Cc: Jimi Xenidis <jimix@pobox.com>,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"David S. Miller" <davem@davemloft.net>,
Julian Calaby <julian.calaby@gmail.com>
Subject: Re: [PATCH v2] drivers/of: Constify device_node->name and ->path_component_name
Date: Thu, 29 Nov 2012 16:34:16 +0000 [thread overview]
Message-ID: <20121129163416.7CC4F3E0A04@localhost> (raw)
In-Reply-To: <23435.1354059964@neuling.org>
On Wed, 28 Nov 2012 10:46:04 +1100, Michael Neuling <mikey@neuling.org> wrote:
> > Neither of these should ever be changed once set. Make them const and
> > fix up the users that try to modify it in-place. In one case
> > kmalloc+memcpy is replaced with kstrdup() to avoid modifying the string.
> >
> > Build tested with defconfigs on ARM, PowerPC, Sparc, MIPS, x86 among
> > others.
>
> Grant,
>
> This breaks powerpc chroma_defconfig in next-20121127 with:
>
> arch/powerpc/sysdev/scom.c:160:17: error: assignment discards 'const' qualifier from pointer target type [-Werror]
>
> The following fixes it. The change is to generic code, so I'm not sure
> it's the right fix as it may break other configs/archs.
That is rather risky. Post it as a patch to core code, but in the mean
time I'll patch the powerpc scom code.
g.
prev parent reply other threads:[~2012-11-29 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 14:20 [PATCH v2] drivers/of: Constify device_node->name and ->path_component_name Grant Likely
2012-11-16 17:33 ` David Miller
2012-11-27 23:46 ` Michael Neuling
2012-11-29 16:34 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129163416.7CC4F3E0A04@localhost \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jimix@pobox.com \
--cc=julian.calaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).