* [PATCH -next] TTY: hvsi: use for_each_compatible_node() macro
@ 2012-12-04 5:16 Wei Yongjun
2012-12-05 23:36 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-12-04 5:16 UTC (permalink / raw)
To: gregkh, grant.likely, rob.herring
Cc: yongjun_wei, linuxppc-dev, devicetree-discuss, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Use for_each_compatible_node() macro instead of open coding it.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/tty/hvc/hvsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c
index 5b95b4f..70e0ef7 100644
--- a/drivers/tty/hvc/hvsi.c
+++ b/drivers/tty/hvc/hvsi.c
@@ -1187,9 +1187,7 @@ static int __init hvsi_console_init(void)
hvsi_wait = poll_for_state; /* no irqs yet; must poll */
/* search device tree for vty nodes */
- for (vty = of_find_compatible_node(NULL, "serial", "hvterm-protocol");
- vty != NULL;
- vty = of_find_compatible_node(vty, "serial", "hvterm-protocol")) {
+ for_each_compatible_node(vty, "serial", "hvterm-protocol") {
struct hvsi_struct *hp;
const uint32_t *vtermno, *irq;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] TTY: hvsi: use for_each_compatible_node() macro
2012-12-04 5:16 [PATCH -next] TTY: hvsi: use for_each_compatible_node() macro Wei Yongjun
@ 2012-12-05 23:36 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2012-12-05 23:36 UTC (permalink / raw)
To: Wei Yongjun, gregkh, rob.herring
Cc: yongjun_wei, linuxppc-dev, devicetree-discuss, linux-kernel
On Tue, 4 Dec 2012 00:16:18 -0500, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use for_each_compatible_node() macro instead of open coding it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> drivers/tty/hvc/hvsi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c
> index 5b95b4f..70e0ef7 100644
> --- a/drivers/tty/hvc/hvsi.c
> +++ b/drivers/tty/hvc/hvsi.c
> @@ -1187,9 +1187,7 @@ static int __init hvsi_console_init(void)
> hvsi_wait = poll_for_state; /* no irqs yet; must poll */
>
> /* search device tree for vty nodes */
> - for (vty = of_find_compatible_node(NULL, "serial", "hvterm-protocol");
> - vty != NULL;
> - vty = of_find_compatible_node(vty, "serial", "hvterm-protocol")) {
> + for_each_compatible_node(vty, "serial", "hvterm-protocol") {
> struct hvsi_struct *hp;
> const uint32_t *vtermno, *irq;
>
>
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-05 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-04 5:16 [PATCH -next] TTY: hvsi: use for_each_compatible_node() macro Wei Yongjun
2012-12-05 23:36 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).