From: Grant Likely <grant.likely@secretlab.ca>
To: Michal Simek <michal.simek@xilinx.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
linux-arch@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Cc: John Linn <John.Linn@xilinx.com>, John Williams <jwilliams@xilinx.com>
Subject: Re: Sharing PCIE driver between Microblaze and Arm zynq
Date: Fri, 07 Dec 2012 13:17:06 +0000 [thread overview]
Message-ID: <20121207131706.EC9273E0B87@localhost> (raw)
In-Reply-To: <CAHTX3dLxbVxn+D+AV7L0VsGYFOjas3AJ_3M_xncVfxp02FCy=Q@mail.gmail.com>
On Thu, 6 Dec 2012 15:23:14 +0100, Michal Simek <michal.simek@xilinx.com> wrote:
> Hi guys,
>
> I have a question regarding to sharing generic OF pcie driver between
> two architectures MB and ARM Zynq.
> Is drivers/pci/pcie location good for it?
> Make no sense to have the same driver in two locations.
> Is using readl/writel IO functions in this driver the best option
> which we can have?
> Or is there any other recommendation?
>
> Also just want to check if it is correct to use pcie device_type.
> The rest should be the same with pci description:
> (http://devicetree.org/MPC5200:PCI#PCI_Address_Translation).
Yes. device_type may be deprecated, but the PCI binding predates that.
PowerPC uses pcie in the device type. arch/powerpc/kernel/of_platform.c
Some of that powerpc DT PCI support code really should be made generic.
g.
next prev parent reply other threads:[~2012-12-07 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 14:23 Sharing PCIE driver between Microblaze and Arm zynq Michal Simek
2012-12-06 21:27 ` Bjorn Helgaas
2012-12-07 9:45 ` Michal Simek
2012-12-07 14:11 ` Grant Likely
2012-12-10 7:34 ` Michal Simek
2012-12-07 19:07 ` Arnd Bergmann
2012-12-10 7:36 ` Michal Simek
2012-12-07 13:17 ` Grant Likely [this message]
2012-12-07 18:52 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207131706.EC9273E0B87@localhost \
--to=grant.likely@secretlab.ca \
--cc=John.Linn@xilinx.com \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jwilliams@xilinx.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).