From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>
Subject: [PATCH] of: Support a PCI device that is compatible with 'simple-bus'
Date: Mon, 10 Dec 2012 14:51:19 -0700 [thread overview]
Message-ID: <20121210215119.GA32011@obsidianresearch.com> (raw)
The intended use for this feature is to let a PCI device declare
itself a 'simple-bus' and then describe additional devices
(such as GPIOs, I2C, etc) nested below itself.
The devices nested below the PCI device will use 'reg' addressing
with the 5 dw format used by PCI.
This is for embedded cases where the PCI device may be a complex
SOC with no PCI based partitioning of sub-functionality.
Tested on an ARM kirkwood system
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
---
drivers/of/address.c | 29 +++++++++++++++++++++++++++++
1 files changed, 29 insertions(+), 0 deletions(-)
Grant:
> If the soc_devices are getting triggered on that and they shouldn't be,
> then we need a mechanism in the soc_bridge node to kick out of that
> behavoir for its children.
Is this what you were thinking?
diff --git a/drivers/of/address.c b/drivers/of/address.c
index 0125524..cf9dac5 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -110,6 +110,25 @@ static int of_bus_pci_match(struct device_node *np)
return !strcmp(np->type, "pci") || !strcmp(np->type, "vci");
}
+/*
+ * When simple-bus is nested below a PCI bus then we treat the simple-bus
+ * as having the same 3 address/2 size semantics as the PCI bus, but create
+ * platform devices like normal.
+ */
+static int of_bus_platform_pci_match(struct device_node *np)
+{
+ struct device_node *parent;
+ int parent_is_pci;
+
+ parent = of_get_parent(np);
+ if (parent == NULL)
+ return 0;
+ parent_is_pci = of_bus_pci_match(parent);
+ of_node_put(parent);
+
+ return parent_is_pci && of_device_is_compatible(np, "simple-bus");
+}
+
static void of_bus_pci_count_cells(struct device_node *np,
int *addrc, int *sizec)
{
@@ -293,6 +312,16 @@ static unsigned int of_bus_isa_get_flags(const __be32 *addr)
static struct of_bus of_busses[] = {
#ifdef CONFIG_PCI
+ /* Platform devices beneath a PCI device */
+ {
+ .name = "platform_pci",
+ .addresses = "reg",
+ .match = of_bus_platform_pci_match,
+ .count_cells = of_bus_pci_count_cells,
+ .map = of_bus_pci_map,
+ .translate = of_bus_pci_translate,
+ .get_flags = of_bus_pci_get_flags,
+ },
/* PCI */
{
.name = "pci",
--
1.7.5.4
next reply other threads:[~2012-12-10 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 21:51 Jason Gunthorpe [this message]
2012-12-14 20:26 ` [PATCH] of: Support a PCI device that is compatible with 'simple-bus' Grant Likely
2012-12-14 21:58 ` Jason Gunthorpe
[not found] ` <20121214215814.GA14149-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-12-19 12:54 ` Grant Likely
2012-12-19 19:18 ` Jason Gunthorpe
2013-03-04 2:55 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210215119.GA32011@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).