From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP Date: Mon, 10 Dec 2012 23:37:23 +0100 Message-ID: <20121210233723.1f3656d0@skate> References: <1355136122-30729-1-git-send-email-gregory.clement@free-electrons.com> <1355136122-30729-2-git-send-email-gregory.clement@free-electrons.com> <20121210162819.46fe4f91@skate> <20121210214755.9CD823E0C7C@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121210214755.9CD823E0C7C@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Grant Likely Cc: Lior Amsalem , Andrew Lunn , Ike Pan , Nadav Haklai , David Marlin , Yehuda Yitschak , Jani Monoses , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Alessandro Zummo , Jon Masters , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Chris Van Hoof , Maen Suleiman , Shadi Ammouri List-Id: devicetree@vger.kernel.org Dear Grant Likely, On Mon, 10 Dec 2012 21:47:55 +0000, Grant Likely wrote: > > Maybe an explicit status = "okay" here? > > Only necessary if it is typical for the device to get disabled. I don't > add status="okay" properties unless it is to enable a device previously > disabled with status="disabled" Ok, thanks for clarifying what the best practice is. This device being internal to the SoC and having no dependency on external components, it is indeed always available. Thanks again for the clarification! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com