[PATCH 0/2] add RTC support for Armada 370 and Armada XP

[PATCH 0/2] add RTC support for Armada 370 and Armada XP

[Gregory CLEMENT]

Hello Jason,

This small patchset adds RTC support for Armada 370 and Armada XP. It
was succesfully tested on the evaluation board. The second patch add
the lacking documentation for the device tree binding. This serie is
3.9 material.

Thanks,


Gregory CLEMENT (2):
  arm: mvebu: add RTC support for Armada 370 and Armada XP
  rtc: rtc-mv: Add the device tree binding documentation

 .../devicetree/bindings/rtc/orion-rtc.txt          |   18 ++++++++++++++++++
 arch/arm/boot/dts/armada-370-xp.dtsi               |    6 ++++++
 drivers/rtc/Kconfig                                |    2 +-
 3 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/rtc/orion-rtc.txt

-- 
1.7.9.5

[PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

[Gregory CLEMENT]

The Armada 370 and Armada XP Socs have the same controller that the
one used in the orion platforms. This patch enables the selection of
rtc-mv with mvebu platform, and updates the device tree for these
SoCs.
---
 arch/arm/boot/dts/armada-370-xp.dtsi |    6 ++++++
 drivers/rtc/Kconfig                  |    2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
index cf6c48a..86dccfa 100644
--- a/arch/arm/boot/dts/armada-370-xp.dtsi
+++ b/arch/arm/boot/dts/armada-370-xp.dtsi
@@ -129,6 +129,12 @@
 			clocks = <&coreclk 0>;
 			status = "disabled";
 		};
+
+		rtc@10300 {
+			compatible = "marvell,orion-rtc";
+			reg = <0xd0010300 0x20>;
+			interrupts = <50>;
+		};
 	};
 };
 
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 19c03ab..9356f75 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -994,7 +994,7 @@ config RTC_DRV_TX4939
 
 config RTC_DRV_MV
 	tristate "Marvell SoC RTC"
-	depends on ARCH_KIRKWOOD || ARCH_DOVE
+	depends on ARCH_KIRKWOOD || ARCH_DOVE || ARCH_MVEBU
 	help
 	  If you say yes here you will get support for the in-chip RTC
 	  that can be found in some of Marvell's SoC devices, such as
-- 
1.7.9.5

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

[Thomas Petazzoni]

Dear Gregory CLEMENT,

On Mon, 10 Dec 2012 11:42:01 +0100, Gregory CLEMENT wrote:

> +		rtc@10300 {
> +			compatible = "marvell,orion-rtc";
> +			reg = <0xd0010300 0x20>;
> +			interrupts = <50>;
> +		};

Maybe an explicit status = "okay" here?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

[Grant Likely]

On Mon, 10 Dec 2012 16:28:19 +0100, Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Dear Gregory CLEMENT,
> 
> On Mon, 10 Dec 2012 11:42:01 +0100, Gregory CLEMENT wrote:
> 
> > +		rtc@10300 {
> > +			compatible = "marvell,orion-rtc";
> > +			reg = <0xd0010300 0x20>;
> > +			interrupts = <50>;
> > +		};
> 
> Maybe an explicit status = "okay" here?

Only necessary if it is typical for the device to get disabled. I don't
add status="okay" properties unless it is to enable a device previously
disabled with status="disabled"

g.

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

[Thomas Petazzoni]

Dear Grant Likely,

On Mon, 10 Dec 2012 21:47:55 +0000, Grant Likely wrote:

> > Maybe an explicit status = "okay" here?
> 
> Only necessary if it is typical for the device to get disabled. I don't
> add status="okay" properties unless it is to enable a device previously
> disabled with status="disabled"

Ok, thanks for clarifying what the best practice is. This device being
internal to the SoC and having no dependency on external components, it
is indeed always available.

Thanks again for the clarification!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

[Andrew Lunn]

On Mon, Dec 10, 2012 at 11:37:23PM +0100, Thomas Petazzoni wrote:
> Dear Grant Likely,
> 
> On Mon, 10 Dec 2012 21:47:55 +0000, Grant Likely wrote:
> 
> > > Maybe an explicit status = "okay" here?
> > 
> > Only necessary if it is typical for the device to get disabled. I don't
> > add status="okay" properties unless it is to enable a device previously
> > disabled with status="disabled"
> 
> Ok, thanks for clarifying what the best practice is. This device being
> internal to the SoC and having no dependency on external components, it
> is indeed always available.

Hi Thomas

This is not actually true. Its dependent on at least one external
component, a battery. The driver determines at load time if the clock
is ticking.

There are a few Kirkwood and XP designs which use an external i2c RTC,
because the battery recommended by Marvell is mechanically not so easy
to attached to the board, in a robust way.

So i expect some boards will disable this from there own .dts file.
However, defaulting to enabled would make sense.

   Andrew

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

[Thomas Petazzoni]

Dear Andrew Lunn,

On Tue, 11 Dec 2012 07:00:50 +0100, Andrew Lunn wrote:

> This is not actually true. Its dependent on at least one external
> component, a battery. The driver determines at load time if the clock
> is ticking.
> 
> There are a few Kirkwood and XP designs which use an external i2c RTC,
> because the battery recommended by Marvell is mechanically not so easy
> to attached to the board, in a robust way.
> 
> So i expect some boards will disable this from there own .dts file.
> However, defaulting to enabled would make sense.

Ok, thanks for the clarification!

Indeed, the OpenBlocks for example has a RTC on I2C, so maybe it'll
want to disable the on-SoC RTC.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 2/2] rtc: rtc-mv: Add the device tree binding documentation

[Gregory CLEMENT]

The support was already written, but the binding documentation was
lacking.

Signed-off-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
---
 .../devicetree/bindings/rtc/orion-rtc.txt          |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/orion-rtc.txt

diff --git a/Documentation/devicetree/bindings/rtc/orion-rtc.txt b/Documentation/devicetree/bindings/rtc/orion-rtc.txt
new file mode 100644
index 0000000..3bf63ff
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/orion-rtc.txt
@@ -0,0 +1,18 @@
+* Mvebu Real Time Clock
+
+RTC controller for the Kirkwood, the Dove, the Armada 370 and the
+Armada XP SoCs
+
+Required properties:
+- compatible : Should be "marvell,orion-rtc"
+- reg: physical base address of the controller and length of memory mapped
+  region.
+- interrupts: IRQ line for the RTC.
+
+Example:
+
+rtc@10300 {
+        compatible = "marvell,orion-rtc";
+        reg = <0xd0010300 0x20>;
+        interrupts = <50>;
+};
-- 
1.7.9.5

Re: [PATCH 2/2] rtc: rtc-mv: Add the device tree binding documentation

[Jason Cooper]

On Mon, Dec 10, 2012 at 11:42:02AM +0100, Gregory CLEMENT wrote:
> The support was already written, but the binding documentation was
> lacking.

Thanks for doing this, Gregory.  I missed this the first time around
when we added the DT bindings to the rtc driver.

thx,

Jason.

> 
> Signed-off-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
>  .../devicetree/bindings/rtc/orion-rtc.txt          |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/orion-rtc.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/orion-rtc.txt b/Documentation/devicetree/bindings/rtc/orion-rtc.txt
> new file mode 100644
> index 0000000..3bf63ff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/orion-rtc.txt
> @@ -0,0 +1,18 @@
> +* Mvebu Real Time Clock
> +
> +RTC controller for the Kirkwood, the Dove, the Armada 370 and the
> +Armada XP SoCs
> +
> +Required properties:
> +- compatible : Should be "marvell,orion-rtc"
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +- interrupts: IRQ line for the RTC.
> +
> +Example:
> +
> +rtc@10300 {
> +        compatible = "marvell,orion-rtc";
> +        reg = <0xd0010300 0x20>;
> +        interrupts = <50>;
> +};
> -- 
> 1.7.9.5
> 

Re: [PATCH 2/2] rtc: rtc-mv: Add the device tree binding documentation

[Grant Likely]

On Mon, 10 Dec 2012 08:39:14 -0500, Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> wrote:
> On Mon, Dec 10, 2012 at 11:42:02AM +0100, Gregory CLEMENT wrote:
> > The support was already written, but the binding documentation was
> > lacking.
> 
> Thanks for doing this, Gregory.  I missed this the first time around
> when we added the DT bindings to the rtc driver.
> 
> thx,

Applied the documentation patch, thanks. The code patch should go
through the rtc tree.

g.

> 
> Jason.
> 
> > 
> > Signed-off-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> > ---
> >  .../devicetree/bindings/rtc/orion-rtc.txt          |   18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/rtc/orion-rtc.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/orion-rtc.txt b/Documentation/devicetree/bindings/rtc/orion-rtc.txt
> > new file mode 100644
> > index 0000000..3bf63ff
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/orion-rtc.txt
> > @@ -0,0 +1,18 @@
> > +* Mvebu Real Time Clock
> > +
> > +RTC controller for the Kirkwood, the Dove, the Armada 370 and the
> > +Armada XP SoCs
> > +
> > +Required properties:
> > +- compatible : Should be "marvell,orion-rtc"
> > +- reg: physical base address of the controller and length of memory mapped
> > +  region.
> > +- interrupts: IRQ line for the RTC.
> > +
> > +Example:
> > +
> > +rtc@10300 {
> > +        compatible = "marvell,orion-rtc";
> > +        reg = <0xd0010300 0x20>;
> > +        interrupts = <50>;
> > +};
> > -- 
> > 1.7.9.5
> > 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.

Re: [PATCH 0/2] add RTC support for Armada 370 and Armada XP

[Andrew Lunn]

On Mon, Dec 10, 2012 at 11:42:00AM +0100, Gregory CLEMENT wrote:
> Hello Jason,
> 
> This small patchset adds RTC support for Armada 370 and Armada XP. It
> was succesfully tested on the evaluation board. The second patch add
> the lacking documentation for the device tree binding. This serie is
> 3.9 material.

Acked-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

	  Andrew
> 
> Thanks,
> 
> 
> Gregory CLEMENT (2):
>   arm: mvebu: add RTC support for Armada 370 and Armada XP
>   rtc: rtc-mv: Add the device tree binding documentation
> 
>  .../devicetree/bindings/rtc/orion-rtc.txt          |   18 ++++++++++++++++++
>  arch/arm/boot/dts/armada-370-xp.dtsi               |    6 ++++++
>  drivers/rtc/Kconfig                                |    2 +-
>  3 files changed, 25 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/rtc/orion-rtc.txt
> 
> -- 
> 1.7.9.5
> 

Re: [PATCH 0/2] add RTC support for Armada 370 and Armada XP

[Thomas Petazzoni]

Dear Gregory CLEMENT,

On Mon, 10 Dec 2012 11:42:00 +0100, Gregory CLEMENT wrote:

> This small patchset adds RTC support for Armada 370 and Armada XP. It
> was succesfully tested on the evaluation board. The second patch add
> the lacking documentation for the device tree binding. This serie is
> 3.9 material.
> 
> Thanks,
> 
> 
> Gregory CLEMENT (2):
>   arm: mvebu: add RTC support for Armada 370 and Armada XP
>   rtc: rtc-mv: Add the device tree binding documentation

Would you mind adding a patch that updates the mvebu_defconfig to
include the RTC driver by default?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH 0/2] add RTC support for Armada 370 and Armada XP

[Gregory CLEMENT]

On 12/10/2012 03:01 PM, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
> 
> On Mon, 10 Dec 2012 11:42:00 +0100, Gregory CLEMENT wrote:
> 
>> This small patchset adds RTC support for Armada 370 and Armada XP. It
>> was succesfully tested on the evaluation board. The second patch add
>> the lacking documentation for the device tree binding. This serie is
>> 3.9 material.
>>
>> Thanks,
>>
>>
>> Gregory CLEMENT (2):
>>   arm: mvebu: add RTC support for Armada 370 and Armada XP
>>   rtc: rtc-mv: Add the device tree binding documentation
> 
> Would you mind adding a patch that updates the mvebu_defconfig to
> include the RTC driver by default?

Sure. I will.

> 
> Thanks!
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com