From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes Date: Tue, 11 Dec 2012 21:57:14 +0900 Message-ID: <20121211125713.GH9097@opensource.wolfsonmicro.com> References: <1355120784-31118-1-git-send-email-a.kesavan@samsung.com> <1355120784-31118-2-git-send-email-a.kesavan@samsung.com> <1355120784-31118-3-git-send-email-a.kesavan@samsung.com> <20121210064650.GJ10927@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3yNHWXBV/QO9xKNm" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Abhilash Kesavan Cc: linux-kernel@vger.kernel.org, lrg@ti.com, Olof Johansson , Doug Anderson , Thomas Abraham , Kukjin Kim , Grant Likely , devicetree-discuss@lists.ozlabs.org, sameo@linux.intel.com List-Id: devicetree@vger.kernel.org --3yNHWXBV/QO9xKNm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 10, 2012 at 02:06:49PM +0530, Abhilash Kesavan wrote: > On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan > wrote: > > Mark Brown opensource.wolfsonmicro.com> writes: > >> Binding documenation is mandatory for any new OF properties, please add > >> this. > > Patch 3/3 of this series adds documentation for the max77686-opmode property. There is no point in splitting changes like this up, it just makes review harder - in this case it caused me to not read your patch due to the missing documentation. Put the whole change together unless things are getting too big to review. --3yNHWXBV/QO9xKNm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQxy1XAAoJELSic+t+oim9NN4QAJniZUKtXd8T+0qAbauGhp/i nnvPtBVz9qVM2ePxP38sizAhPWh7ScPfcc0mQwNvj3cTeiQiWYDI+HeXqOmgGb+W h39JvQ8xJmRCICe+yaWzgwW0aGvl4rlQKsEMkqJVZY+A8vF+bQCrxp+1sI8bnsCA FjCPgl5YS7M7mYX3qRql+B6r7G7sEKV3lKZgPqSIgjCLOv5DZc5Vj+pqLMtskkFi L6C6OyRAQ6a6muO+N1p6t4yRKevyEoSkdfS0usc8+vwC34jxd8140FOVvoFWw2Xf 8qkzzo/D2BKw4H3CmX16EmbiyAtjEfDbqGpUCKtQCYGzGswiBa4CzbQOe0ORO0kp DDF1FrCgnYYIZlFdpFi4IFfCLNKV0+BwGpbq0aBSza+Sf7mBthvMHlNsTVeH9eSa /4U7aZRR1z9gJpNmz47ttppPZYa8sQ2J45mLSvVKmCAOeuxXL8dl2ENect6T5yGt u4s2UzFNRXJMduqs+TIq/RoLyxssI8Sx8fK3meNXpLEboWTjBf3VMM2AgiQcHbp5 vam7Y6CX/oK4EqQRGST4ggmgkPjFTFD2H3bHW9PnEI5yXn6CQD5sZVjKYocnsH7a 5/MFC8SrnbN55hfRpnvYX/RUeZ1o/usmRM60Twde5KuVqvV8IeXBsc9oWQLd5/V9 eqpxHw+qoYQSKDWUnfYs =Vd+K -----END PGP SIGNATURE----- --3yNHWXBV/QO9xKNm--