From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: spi-devel-general@lists.sourceforge.net,
devicetree-discuss@lists.ozlabs.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] spi/atmel: add DT support
Date: Mon, 17 Dec 2012 11:13:51 +0100 [thread overview]
Message-ID: <20121217101351.GI23971@game.jcrosoft.org> (raw)
In-Reply-To: <20121215010317.C9C933E0BEC@localhost>
On 01:03 Sat 15 Dec , Grant Likely wrote:
> On Wed, 12 Dec 2012 16:13:08 +0100, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote:
> > On 14:37 Fri 23 Nov , Nicolas Ferre wrote:
> > > On 11/23/2012 01:44 PM, Jean-Christophe PLAGNIOL-VILLARD :
> > > > the atmel_spi use only gpio for chip select
> > > >
> > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > >
> > > Seems simple and nice:
> > >
> > > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > grant is ok to have this for 3.8?
>
> Not sure how I missed this one. It's pretty straight forward and not
> risky, so no problem. However;
>
> > > > the atmel_spi use only gpio for chip select
>
> I know you know how to write a proper commit message. I'll need
> something better than the above before I commit it. I won't make you
> resubmit the patch, but do send me a better description.
>
ok replace with this please
spi/atmel: add DT support
Use the newly introduce cs-gpios dt support on atmel.
We do not use the hardware cs as it's wired and have buges and limitations.
As the the controller's belief that only active-low devices/systems exists.
As done on non-dt system.
Best Regards,
J.
> g.
>
next prev parent reply other threads:[~2012-12-17 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1349850454-21127-1-git-send-email-wenyou.yang@atmel.com>
[not found] ` <1349850454-21127-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-10-10 6:27 ` [PATCH 02/16] of_spi: add generic binding support to specify cs gpio Wenyou Yang
[not found] ` <1349850454-21127-3-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-15 16:50 ` Grant Likely
2012-11-15 19:19 ` [PATCH 1/1 v2] " Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1353007197-31491-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2012-11-21 15:17 ` Grant Likely
2012-11-23 12:44 ` [PATCH 1/1] spi/atmel: add DT support Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1353674679-13158-1-git-send-email-plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
2012-11-23 13:37 ` Nicolas Ferre
2012-12-12 15:13 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20121212151308.GK4398-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-12-15 1:03 ` Grant Likely
2012-12-17 10:13 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
[not found] ` <20121217101351.GI23971-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2012-12-17 17:15 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217101351.GI23971@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).