From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Simon Horman <horms+renesas@verge.net.au>,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org,
Paul Mundt <lethal@linux-sh.org>,
Magnus Damm <magnus.damm@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Bastian Hecht <hechtb@gmail.com>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
Magnus Damm <damm@opensource.se>
Subject: Re: [PATCH 02/10] SH: intc: Add support OF of IRQ
Date: Tue, 18 Dec 2012 09:31:50 +0900 [thread overview]
Message-ID: <20121218003150.GH7146@verge.net.au> (raw)
In-Reply-To: <2838757.yMqfipzqR7@avalon>
On Mon, Dec 17, 2012 at 09:29:44AM +0100, Laurent Pinchart wrote:
> Hi Iwamatsu-san,
>
> Thank your for the patch.
>
> On Saturday 15 December 2012 18:03:36 Simon Horman wrote:
> > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> >
> > Add information of device node to struct intc_desc.
> >
> > Cc: Magnus Damm <damm@opensource.se>
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > ---
> >
> > v7
> > * Delete "renesas,sh_intcs" and "renesas,sh_intca_irq_pins" as compatible.
> > Update their documentation.
> > * Remove of_sh_intc_get_meminfo() and of_sh_intc_get_pint and
> > of_sh_intc_get_intc(). They are not used.
> >
> > v2 - v6
> > * No change
> > ---
> > Documentation/devicetree/bindings/sh/intc.txt | 15 +----
> > drivers/sh/intc/core.c | 2 +-
> > drivers/sh/intc/internals.h | 3 +-
> > drivers/sh/intc/irqdomain.c | 6 +-
> > drivers/sh/intc/of_intc.c | 76 ----------------------
> > include/linux/sh_intc.h | 29 +---------
> > 6 files changed, 9 insertions(+), 122 deletions(-)
>
> Shouldn't this be squashed into patch 01/10 ? 01/10 adds DT bindings support,
> and you already modify them in this patch.
Good point. Yes, I think so.
I'll probably be the one doing the squashing and if so I'll do so for the
next spin.
next prev parent reply other threads:[~2012-12-18 0:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 9:03 [RFC v7 00/10] ARM: shmobile: DT initialisation of INTC and GIC Simon Horman
2012-12-15 9:03 ` [PATCH 01/10] ARM: shmobile: Add support OF for INTC of shmobile Simon Horman
2012-12-18 10:00 ` Mark Rutland
[not found] ` <20121218095853.GA29231-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-01-08 8:20 ` Simon Horman
2012-12-15 9:03 ` [PATCH 02/10] SH: intc: Add support OF of IRQ Simon Horman
2012-12-17 8:29 ` Laurent Pinchart
2012-12-18 0:31 ` Simon Horman [this message]
2012-12-15 9:03 ` [PATCH 03/10] ARM: shmobile: Add support OF of INTC for r8a7740 Simon Horman
2012-12-15 9:03 ` [PATCH 04/10] ARM: shmobile: Add support OF of INTC for sh7372 Simon Horman
2012-12-15 9:03 ` [PATCH 05/10] ARM: shmobile: Add DT table " Simon Horman
2012-12-17 8:44 ` Guennadi Liakhovetski
2012-12-18 0:37 ` Simon Horman
2012-12-18 9:34 ` Guennadi Liakhovetski
2012-12-15 9:03 ` [PATCH 06/10] ARM: shmobile: Add DT table of INTC for r8a7740 Simon Horman
2012-12-15 9:03 ` [PATCH 07/10] ARM: shmobile: Include DTSI of r8a7740 to armadillo800eva Simon Horman
2012-12-15 9:03 ` [PATCH 08/10] ARM: shmobile: r8a7740: Use DT initialisation of INTC Simon Horman
2012-12-15 9:03 ` [PATCH 09/10] ARM: shmobile: sh7372: Do not initialise TMU when using DT Simon Horman
2012-12-17 9:58 ` Guennadi Liakhovetski
2012-12-18 0:39 ` Simon Horman
2012-12-15 9:03 ` [PATCH 10/10] ARM: shmobile: sh7372: Use DT initialisation of INTC Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121218003150.GH7146@verge.net.au \
--to=horms@verge.net.au \
--cc=damm@opensource.se \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=g.liakhovetski@gmx.de \
--cc=hechtb@gmail.com \
--cc=horms+renesas@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).