[PATCH] of: add 'const' to of_node_full_name parameter

[PATCH] of: add 'const' to of_node_full_name parameter

[Steffen Trumtrar]

As the function just returns the np->full_name or the string "<no-node>", the
passed device_node pointer is not changed in any way.

The passed parameter can therefore be a const pointer.

Also, fix the following error from checkpatch.pl:

ERROR: "foo* bar" should be "foo *bar"
+static inline const char* of_node_full_name(const struct device_node *np)

Signed-off-by: Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
 include/linux/of.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/of.h b/include/linux/of.h
index b4e50d5..f525390 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -159,7 +159,7 @@ static inline unsigned long of_read_ulong(const __be32 *cell, int size)
 
 #define OF_BAD_ADDR	((u64)-1)
 
-static inline const char* of_node_full_name(struct device_node *np)
+static inline const char *of_node_full_name(const struct device_node *np)
 {
 	return np ? np->full_name : "<no-node>";
 }
-- 
1.7.10.4

Re: [PATCH] of: add 'const' to of_node_full_name parameter

[Grant Likely]

On Tue, 18 Dec 2012 11:32:03 +0100, Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> As the function just returns the np->full_name or the string "<no-node>", the
> passed device_node pointer is not changed in any way.
> 
> The passed parameter can therefore be a const pointer.
> 
> Also, fix the following error from checkpatch.pl:
> 
> ERROR: "foo* bar" should be "foo *bar"
> +static inline const char* of_node_full_name(const struct device_node *np)
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Applied, thanks. Will show up in linux-next after the v3.8 merge window closes.

g.