From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] of: add 'const' to of_node_full_name parameter Date: Wed, 19 Dec 2012 13:13:24 +0000 Message-ID: <20121219131324.2DD993E0AD7@localhost> References: <1355826723-27763-1-git-send-email-s.trumtrar@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1355826723-27763-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Cc: Steffen Trumtrar , Rob Herring List-Id: devicetree@vger.kernel.org On Tue, 18 Dec 2012 11:32:03 +0100, Steffen Trumtrar wrote: > As the function just returns the np->full_name or the string "", the > passed device_node pointer is not changed in any way. > > The passed parameter can therefore be a const pointer. > > Also, fix the following error from checkpatch.pl: > > ERROR: "foo* bar" should be "foo *bar" > +static inline const char* of_node_full_name(const struct device_node *np) > > Signed-off-by: Steffen Trumtrar Applied, thanks. Will show up in linux-next after the v3.8 merge window closes. g.