From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: CoreSight framework and drivers Date: Sun, 23 Dec 2012 11:32:39 +0000 Message-ID: <20121223113239.GG16237@mudshark.cambridge.arm.com> References: <1355858365-11849-1-git-send-email-pratikp@codeaurora.org> <20121219112314.GA26329@mudshark.cambridge.arm.com> <50D1F37E.6000804@ti.com> <20121219212431.GC23594@pratikp-linux.qualcomm.com> <50D34EE5.8090407@ti.com> <20121220195127.GA14877@pratikp-linux.qualcomm.com> <50D3972E.4030607@ti.com> <20121221221828.GA2658@pratikp-linux.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20121221221828.GA2658-9H3kiKr51/JHGpnEYu0o6d07Fnf2crXX0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Pratik Patel Cc: "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , "linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "magnus.p.persson-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org" , "david.rusling-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "arve-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org" , "dsaxena-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "d-deao-l0cyMroinI0@public.gmane.org" , "christian.bejram-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, Dec 21, 2012 at 10:18:28PM +0000, Pratik Patel wrote: > What user interface do you plan to provide for the CTI? Maybe > something consistent with other CoreSight components in sysfs to > allow users to enable, disable, map and unmap ??? > > Please let me know your thoughts. Rather than have your current approach of dev nodes + sysfs config files for each coresight device, I think it might be better to follow something closer to ftrace and stick per-device directories under debugfs/coresight/. Then you can have a pipe file and some config files in the same directory for each component. You also don't need to do any mapping operations with this (just post-process the stream directly). It might also be fun to play with file redirection for sources and sinks, but that's probably a bit too invasive. Will