From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com, lrg@ti.com,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] regulator: tps51632: add register property for regmap
Date: Thu, 27 Dec 2012 17:32:33 +0000 [thread overview]
Message-ID: <20121227173233.GI5005@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1356447960-6084-1-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Tue, Dec 25, 2012 at 08:35:59PM +0530, Laxman Dewangan wrote:
> All TPS51632 registers are not readable/writable and
> non-volatiles.
Applied both, thanks, but you might wish to consider...
> +static bool is_read_reg(struct device *dev, unsigned int reg)
> +{
> + switch (reg) {
> + case 0x08 ... 0x0F:
> + return false;
> + default:
> + return true;
> + }
> +}
...using the new table based stuff for the access checks, at least this
one seems to map on nicely.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-12-27 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-25 15:05 [PATCH V2 1/2] regulator: tps51632: add register property for regmap Laxman Dewangan
[not found] ` <1356447960-6084-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-25 15:06 ` [PATCH V2 2/2] regulator: tps51632: add DT support Laxman Dewangan
2012-12-27 17:32 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121227173233.GI5005@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).