From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux ARM
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] cpuidle: kirkwood: Move out of mach directory, add DT.
Date: Fri, 28 Dec 2012 15:37:13 +0100 [thread overview]
Message-ID: <20121228143713.GB5172@lunn.ch> (raw)
In-Reply-To: <50DDAD68.4090704-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
On Fri, Dec 28, 2012 at 03:32:08PM +0100, Florian Fainelli wrote:
> Hello Andrew,
>
> Le 12/28/12 13:47, Andrew Lunn a ??crit :
> >Move the Kirkwood cpuidle driver out of arch/arm/mach-kirkwood and
> >into drivers/cpuidle. Convert the driver into a platform driver and
> >add a device tree binding. Add a DT node to instantiate the driver for
> >boards converted to DT, and a platform data for old style boards.
> >
> >Signed-off-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
> >---
>
> [snip]
>
> >
> >+/*****************************************************************************
> >+ * CPU idle
> >+ ****************************************************************************/
> >+static struct resource kirkwood_cpuidle_resource[] = {
> >+ {
> >+ .flags = IORESOURCE_MEM,
> >+ .start = DDR_OPERATION_BASE,
> >+ .end = 3,
>
> Should not this be DDR_OPERATION_BASE + 3?
Yes it should.
Thanks
Andrew
prev parent reply other threads:[~2012-12-28 14:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 12:47 [PATCH] cpuidle: kirkwood: Move out of mach directory, add DT Andrew Lunn
[not found] ` <1356698844-4220-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2012-12-28 14:18 ` Rob Herring
[not found] ` <50DDAA42.2020101-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-28 14:35 ` Andrew Lunn
[not found] ` <20121228143517.GA5172-g2DYL2Zd6BY@public.gmane.org>
2012-12-28 14:55 ` Rob Herring
[not found] ` <50DDB2E3.103-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-28 15:49 ` Andrew Lunn
[not found] ` <20121228154927.GC5172-g2DYL2Zd6BY@public.gmane.org>
2012-12-28 16:14 ` Rob Herring
[not found] ` <50DDC54A.3020509-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-28 16:38 ` Andrew Lunn
[not found] ` <20121228163815.GD5172-g2DYL2Zd6BY@public.gmane.org>
2012-12-28 16:59 ` Rob Herring
2012-12-28 16:56 ` Santosh Shilimkar
[not found] ` <50DDCF47.1030305-l0cyMroinI0@public.gmane.org>
2012-12-28 17:28 ` Andrew Lunn
[not found] ` <20121228172807.GA7578-g2DYL2Zd6BY@public.gmane.org>
2012-12-28 17:50 ` Santosh Shilimkar
[not found] ` <50DDDBEB.3000002-l0cyMroinI0@public.gmane.org>
2012-12-28 17:56 ` Andrew Lunn
[not found] ` <20121228175618.GC7578-g2DYL2Zd6BY@public.gmane.org>
2012-12-28 18:02 ` Santosh Shilimkar
2013-02-08 21:34 ` Grant Likely
2013-02-10 18:58 ` Andrew Lunn
2013-02-11 11:41 ` Grant Likely
2012-12-28 14:32 ` Florian Fainelli
[not found] ` <50DDAD68.4090704-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2012-12-28 14:37 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121228143713.GB5172@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).