From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: Fix util_is_printable_string Date: Sat, 5 Jan 2013 23:49:36 +1100 Message-ID: <20130105124936.GE4674@truffula.fritz.box> References: <1357326778-12725-1-git-send-email-panto@antoniou-consulting.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6198471465466548880==" Return-path: In-Reply-To: <1357326778-12725-1-git-send-email-panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Pantelis Antoniou Cc: Matt Porter , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Russ Dill List-Id: devicetree@vger.kernel.org --===============6198471465466548880== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r7U+bLA8boMOj+mD" Content-Disposition: inline --r7U+bLA8boMOj+mD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 04, 2013 at 09:12:58PM +0200, Pantelis Antoniou wrote: > The method used did not account for multi-part strings. >=20 > Signed-off-by: Pantelis Antoniou I think it could do with some more commenting of exactly what it's considering a printable string(s). I'm pretty sure it's doing the right thing, but if you're not already familiar with the OF multi-string convention, it would be easy to get confused by the code. Other than that Acked-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --r7U+bLA8boMOj+mD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlDoIWAACgkQaILKxv3ab8afkACdFV6ucIb/p95nMaqhVPapwRQ+ TasAmwR+agw0IbAU0QtRI7Gj44DbdAuU =Oot0 -----END PGP SIGNATURE----- --r7U+bLA8boMOj+mD-- --===============6198471465466548880== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============6198471465466548880==--