Fix test relying in wrong behavior of is_printable

Fix test relying in wrong behavior of is_printable

[Pantelis Antoniou]

After fixing the is_printable bug the test suite fails.
Fix it with this patch

Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
---
 tests/run_tests.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index dd7f217..43279c9 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -498,9 +498,8 @@ fdtget_tests () {
 
     # run_fdtget_test <expected-result> [<flags>] <file> <node> <property>
     run_fdtget_test "MyBoardName" $dtb / model
-    run_fdtget_test "77 121 66 111 \
-97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 \
-108 121 78 97 109 101 0" $dtb / compatible
+    # run_fdtget_test "77 121 66 111 97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 108 121 78 97 109 101 0" $dtb / compatible
+    run_fdtget_test "MyBoardName MyBoardFamilyName" $dtb / compatible
     run_fdtget_test "MyBoardName MyBoardFamilyName" -t s $dtb / compatible
     run_fdtget_test 32768 $dtb /cpus/PowerPC,970@1 d-cache-size
     run_fdtget_test 8000 -tx $dtb /cpus/PowerPC,970@1 d-cache-size
-- 
1.7.12

Re: Fix test relying in wrong behavior of is_printable

[David Gibson]

[-- Attachment #1.1: Type: text/plain, Size: 1593 bytes --]

On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
> After fixing the is_printable bug the test suite fails.
> Fix it with this patch
> 
> Signed-off-by: Pantelis Antoniou <panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>

Rather than just removing the test, it would be better to still run it
using an explicit -t bi to force the byte output.

> ---
>  tests/run_tests.sh | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index dd7f217..43279c9 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -498,9 +498,8 @@ fdtget_tests () {
>  
>      # run_fdtget_test <expected-result> [<flags>] <file> <node> <property>
>      run_fdtget_test "MyBoardName" $dtb / model
> -    run_fdtget_test "77 121 66 111 \
> -97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 \
> -108 121 78 97 109 101 0" $dtb / compatible
> +    # run_fdtget_test "77 121 66 111 97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 108 121 78 97 109 101 0" $dtb / compatible
> +    run_fdtget_test "MyBoardName MyBoardFamilyName" $dtb / compatible
>      run_fdtget_test "MyBoardName MyBoardFamilyName" -t s $dtb / compatible
>      run_fdtget_test 32768 $dtb /cpus/PowerPC,970@1 d-cache-size
>      run_fdtget_test 8000 -tx $dtb /cpus/PowerPC,970@1 d-cache-size

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: Fix test relying in wrong behavior of is_printable

[Pantelis Antoniou]

Hi David

Από το iPhone μου

6 Ιαν 2013, 5:58, ο/η David Gibson <david@gibson.dropbear.id.au> έγραψε:

> On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
>> After fixing the is_printable bug the test suite fails.
>> Fix it with this patch
>> 
>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> 
> Rather than just removing the test, it would be better to still run it
> using an explicit -t bi to force the byte output.

Perhaps it wasn't exactly clear in the patch. The old test case output is commented out but there is test case output for the new patch. 

So the test is not removed. 


Regards

-- Pantelis
> 
>> ---
>> tests/run_tests.sh | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>> 
>> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
>> index dd7f217..43279c9 100755
>> --- a/tests/run_tests.sh
>> +++ b/tests/run_tests.sh
>> @@ -498,9 +498,8 @@ fdtget_tests () {
>> 
>>     # run_fdtget_test <expected-result> [<flags>] <file> <node> <property>
>>     run_fdtget_test "MyBoardName" $dtb / model
>> -    run_fdtget_test "77 121 66 111 \
>> -97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 \
>> -108 121 78 97 109 101 0" $dtb / compatible
>> +    # run_fdtget_test "77 121 66 111 97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 108 121 78 97 109 101 0" $dtb / compatible
>> +    run_fdtget_test "MyBoardName MyBoardFamilyName" $dtb / compatible
>>     run_fdtget_test "MyBoardName MyBoardFamilyName" -t s $dtb / compatible
>>     run_fdtget_test 32768 $dtb /cpus/PowerPC,970@1 d-cache-size
>>     run_fdtget_test 8000 -tx $dtb /cpus/PowerPC,970@1 d-cache-size
> 
> -- 
> David Gibson            | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au    | minimalist, thank you.  NOT _the_ _other_
>                | _way_ _around_!
> http://www.ozlabs.org/~dgibson
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: Fix test relying in wrong behavior of is_printable

[Jon Loeliger]

> Hi David
> 
> =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85
> 
> 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson <david@gibson.dr=
> opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5:
> 
> > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
> >> After fixing the is_printable bug the test suite fails.
> >> Fix it with this patch
> >>=20
> >> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> >=20
> > Rather than just removing the test, it would be better to still run it
> > using an explicit -t bi to force the byte output.
> 
> Perhaps it wasn't exactly clear in the patch. The old test case output is co=
> mmented out but there is test case output for the new patch.=20
> 
> So the test is not removed.=20

Uh, yeah, something needs to be done here still.
(There is a failing test still.)

Could we get a resubmission of the fix, please?

Thanks,
jdl

Re: Fix test relying in wrong behavior of is_printable

[Pantelis Antoniou]

Err,

I can rework and resubmit to remove the comment, but the test doesn't fail:

> $ make check | grep 'MyBoardName.*-t s.*compatible' 
> fdtget-runtest.sh MyBoardName MyBoardFamilyName -t s label01.dts.fdtget.test.dtb / compatible:	PASS
> 

As of today's pull.

Regards

-- Pantelis

On Jan 7, 2013, at 12:14 AM, Jon Loeliger wrote:

>> Hi David
>> 
>> =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85
>> 
>> 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson <david@gibson.dr=
>> opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5:
>> 
>>> On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
>>>> After fixing the is_printable bug the test suite fails.
>>>> Fix it with this patch
>>>> =20
>>>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
>>> =20
>>> Rather than just removing the test, it would be better to still run it
>>> using an explicit -t bi to force the byte output.
>> 
>> Perhaps it wasn't exactly clear in the patch. The old test case output is co=
>> mmented out but there is test case output for the new patch.=20
>> 
>> So the test is not removed.=20
> 
> Uh, yeah, something needs to be done here still.
> (There is a failing test still.)
> 
> Could we get a resubmission of the fix, please?
> 
> Thanks,
> jdl

Re: Fix test relying in wrong behavior of is_printable

[Jon Loeliger]

> Err,
> 
> I can rework and resubmit to remove the comment, but the test doesn't =
> fail:
> 
> > $ make check | grep 'MyBoardName.*-t s.*compatible'
> > fdtget-runtest.sh MyBoardName MyBoardFamilyName -t s label01.dts.fdtget.test.dtb / compatible:	PASS
> >
> 
> As of today's pull.

My build yields:

    $ make check 2>&1 | grep FAIL
    fdtget-runtest.sh 77 121 66 111 97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 108 121 78 97 109 101 0 label01.dts.fdtget.test.dtb / compatible: FAIL Results differ from expected
    *                FAIL:	1

HTH,
jdl

Re: Fix test relying in wrong behavior of is_printable

[David Gibson]

[-- Attachment #1.1: Type: text/plain, Size: 1179 bytes --]

On Sun, Jan 06, 2013 at 01:41:56PM +0200, Pantelis Antoniou wrote:
> Hi David
> 
> Από το iPhone μου
> 
> 6 Ιαν 2013, 5:58, ο/η David Gibson <david@gibson.dropbear.id.au> έγραψε:
> 
> > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
> >> After fixing the is_printable bug the test suite fails.
> >> Fix it with this patch
> >> 
> >> Signed-off-by: Pantelis Antoniou <panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
> > 
> > Rather than just removing the test, it would be better to still run it
> > using an explicit -t bi to force the byte output.
> 
> Perhaps it wasn't exactly clear in the patch. The old test case
> output is commented out but there is test case output for the new
> patch.

I realise that, but that's not my point.  Rather than replacing the
test for the old behaviour with the new one, I'd prefer to keep the
one checking the old behaviour, forcing that behaviour from fdtget
using -t bi

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss