From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: Fix test relying in wrong behavior of is_printable Date: Tue, 8 Jan 2013 19:37:34 +1100 Message-ID: <20130108083734.GA9055@truffula.fritz.box> References: <1357326968-13124-1-git-send-email-panto@antoniou-consulting.com> <20130106035809.GG4674@truffula.fritz.box> <5B13DF52-26BE-4BA1-8BD7-25863B04A3B6@antoniou-consulting.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7190579236703496143==" Return-path: In-Reply-To: <5B13DF52-26BE-4BA1-8BD7-25863B04A3B6-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Pantelis Antoniou Cc: Matt Porter , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Rob Herring , Russ Dill List-Id: devicetree@vger.kernel.org --===============7190579236703496143== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AqsLC8rIMeq19msA" Content-Disposition: inline --AqsLC8rIMeq19msA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 06, 2013 at 01:41:56PM +0200, Pantelis Antoniou wrote: > Hi David >=20 > =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85 >=20 > 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5: >=20 > > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: > >> After fixing the is_printable bug the test suite fails. > >> Fix it with this patch > >>=20 > >> Signed-off-by: Pantelis Antoniou > >=20 > > Rather than just removing the test, it would be better to still run it > > using an explicit -t bi to force the byte output. >=20 > Perhaps it wasn't exactly clear in the patch. The old test case > output is commented out but there is test case output for the new > patch. I realise that, but that's not my point. Rather than replacing the test for the old behaviour with the new one, I'd prefer to keep the one checking the old behaviour, forcing that behaviour from fdtget using -t bi --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --AqsLC8rIMeq19msA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlDr2s4ACgkQaILKxv3ab8bcTQCcCWwSVGgtW22gP1YLmjw3jNlF VjoAn0tBy6jwuB1wayEYQ1Sq6KkwjUJt =qU1p -----END PGP SIGNATURE----- --AqsLC8rIMeq19msA-- --===============7190579236703496143== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============7190579236703496143==--