From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] ARM: kernel: DT cpu map validity check helper function Date: Fri, 11 Jan 2013 16:30:57 +0000 Message-ID: <20130111163057.GE23505@n2100.arm.linux.org.uk> References: <1357921058-11322-1-git-send-email-lorenzo.pieralisi@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1357921058-11322-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Lorenzo Pieralisi Cc: Nicolas Pitre , Kukjin Kim , Pawel Moll , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Magnus Damm , Rob Herring , David Brown , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Hiroshi Doyu List-Id: devicetree@vger.kernel.org On Fri, Jan 11, 2013 at 04:17:38PM +0000, Lorenzo Pieralisi wrote: > This patch implements a helper function that platforms can call to check > whether DT based cpu map initialization and cores count were completed > successfully. Umm, are you sure this works? Two problems here: - the kernel boot marks the booting CPU (in our case, CPU0) as present, possible and online before arch code gets called. smp_init_cpus() will be called with the maps already initialized per that. - this really needs to be paired with a patch showing how you intend it to be used; merely adding the helper without any sign of it being used means it's just bloat which may not end up being used.