From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Pawel Moll <Pawel.Moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Tony Lindgren <tony@atomide.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Magnus Damm <magnus.damm@gmail.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
David Brown <davidb@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Hiroshi Doyu <hdoyu@nvidia.com>
Subject: Re: [PATCH] ARM: kernel: DT cpu map validity check helper function
Date: Fri, 11 Jan 2013 17:20:12 +0000 [thread overview]
Message-ID: <20130111172012.GG30538@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <20130111163057.GE23505@n2100.arm.linux.org.uk>
On Fri, Jan 11, 2013 at 04:30:57PM +0000, Russell King - ARM Linux wrote:
> On Fri, Jan 11, 2013 at 04:17:38PM +0000, Lorenzo Pieralisi wrote:
> > This patch implements a helper function that platforms can call to check
> > whether DT based cpu map initialization and cores count were completed
> > successfully.
>
> Umm, are you sure this works? Two problems here:
> - the kernel boot marks the booting CPU (in our case, CPU0) as present,
> possible and online before arch code gets called. smp_init_cpus()
> will be called with the maps already initialized per that.
Gah, my bad, you are definitely right.
> - this really needs to be paired with a patch showing how you intend it
> to be used; merely adding the helper without any sign of it being used
> means it's just bloat which may not end up being used.
Ok, that's a fair point, I will ask to get it merged with an implementation
that relies on it, showing its usage.
Thanks for the review,
Lorenzo
next prev parent reply other threads:[~2013-01-11 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 16:17 [PATCH] ARM: kernel: DT cpu map validity check helper function Lorenzo Pieralisi
[not found] ` <1357921058-11322-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
2013-01-11 16:30 ` Russell King - ARM Linux
2013-01-11 17:20 ` Lorenzo Pieralisi [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-01-10 11:48 Lorenzo Pieralisi
[not found] ` <1357818507-8716-1-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
2013-01-10 12:15 ` Dave Martin
2013-01-10 12:33 ` Lorenzo Pieralisi
[not found] ` <20130110123321.GD4728-7AyDDHkRsp3ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-01-10 16:16 ` Nicolas Pitre
2013-01-11 10:03 ` Lorenzo Pieralisi
2013-01-10 16:43 ` Rob Herring
2013-01-11 9:59 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111172012.GG30538@e102568-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=davidb@codeaurora.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hdoyu@nvidia.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=nicolas.pitre@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).