From: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
To: Hiroshi Doyu <hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: tegra: Use DT /cpu node to detect number of CPU core
Date: Mon, 14 Jan 2013 09:27:20 +0000 [thread overview]
Message-ID: <20130114092720.GX23505@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1358149970-28156-2-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Mon, Jan 14, 2013 at 09:52:50AM +0200, Hiroshi Doyu wrote:
> + if (!arm_dt_cpu_map_valid())
> + set_cpu_possible(0, true);
You don't need to do any of this (and, therefore, I don't think you even
need the first patch.)
The generic boot code will set CPU0 as possible, present and online. Think
about it: you're booting on that very CPU so it better be possible, present
and online. If it isn't, what CPU is executing your code?
arm_dt_init_cpu_maps() will only ever set _additional_ CPUs in the possible
map.
Ergo, by the time the above code is run, CPU0 will already be marked as
possible. Therefore, the above code and arm_dt_cpu_map_valid() is not
required.
next prev parent reply other threads:[~2013-01-14 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 7:52 [PATCH 1/2] ARM: kernel: DT cpu map validity check helper function Hiroshi Doyu
[not found] ` <1358149970-28156-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-14 7:52 ` [PATCH 2/2] ARM: tegra: Use DT /cpu node to detect number of CPU core Hiroshi Doyu
[not found] ` <1358149970-28156-2-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-14 9:27 ` Russell King - ARM Linux [this message]
[not found] ` <20130114092720.GX23505-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2013-01-14 9:49 ` Hiroshi Doyu
[not found] ` <20130114.114925.1476619399284636466.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-14 12:35 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130114092720.GX23505@n2100.arm.linux.org.uk \
--to=linux-lfz/pmaqli7xmaaqvzeohq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).