From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [patch] hwmon/max6697: fix memset size in max6697_init_chip() Date: Tue, 15 Jan 2013 02:54:02 -0800 Message-ID: <20130115105402.GA21765@roeck-us.net> References: <20130115065308.GA899@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130115065308.GA899-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Dan Carpenter Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, Jean Delvare List-Id: devicetree@vger.kernel.org On Tue, Jan 15, 2013 at 09:53:08AM +0300, Dan Carpenter wrote: > sizeof(p) was intended instead of sizeof(data). data is a pointer and > p is a 7 character struct. It probably doesn't make a difference most > of the time, but it could result in using uninitialized data. > > Signed-off-by: Dan Carpenter > Hi Dan, Thanks a lot! Guenter > diff --git a/drivers/hwmon/max6697.c b/drivers/hwmon/max6697.c > index a1c8c0a..d229cc7 100644 > --- a/drivers/hwmon/max6697.c > +++ b/drivers/hwmon/max6697.c > @@ -474,7 +474,7 @@ static int max6697_init_chip(struct i2c_client *client) > return 0; > > if (!pdata || client->dev.of_node) { > - memset(&p, 0, sizeof(data)); > + memset(&p, 0, sizeof(p)); > max6697_get_config_of(client->dev.of_node, &p); > pdata = &p; > } >