From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: lm-sensors@lm-sensors.org,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4] hwmon: Driver for Maxim MAX6697 and compatibles
Date: Wed, 16 Jan 2013 08:35:39 -0800 [thread overview]
Message-ID: <20130116163539.GA27120@roeck-us.net> (raw)
In-Reply-To: <20130116095331.2e3769f0@endymion.delvare>
On Wed, Jan 16, 2013 at 09:53:31AM +0100, Jean Delvare wrote:
> On Tue, 15 Jan 2013 14:36:27 -0800, Guenter Roeck wrote:
> > Add support for MAX6581, MAX6602, MAX6622, MAX6636, MAX6689, MAX6693,
> > MAX6694, MAX6697, MAX6698, and MAX6699 temperature sensors
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > (...)
> > v4:
> > - s/beta/Beta at beginning of sentence in device tree description file
> > - Optimize temperature calculation in show_temp_input
> > - Accept temperatures up to 255 degrees C (191 degrees C in extended
> > temperature mode) for MAX6581
> > - Define reg as int in max6697_init_chip to be able to catch error cases
> > - Optimize assignment to data->temp_offset in max6697_init_chip
> > - smbus->SMBus in platform_data/max6697.h
> >
> > Documentation/devicetree/bindings/i2c/max6697.txt | 64 ++
> > Documentation/hwmon/max6697 | 58 ++
> > drivers/hwmon/Kconfig | 11 +
> > drivers/hwmon/Makefile | 1 +
> > drivers/hwmon/max6697.c | 726 +++++++++++++++++++++
> > include/linux/platform_data/max6697.h | 36 +
> > 6 files changed, 896 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/i2c/max6697.txt
> > create mode 100644 Documentation/hwmon/max6697
> > create mode 100644 drivers/hwmon/max6697.c
> > create mode 100644 include/linux/platform_data/max6697.h
>
> Reviewed-by: Jean Delvare <khali@linux-fr.org>
>
> Please update lm-sensors' wiki to mention this driver.
>
Done. Thanks a lot for the review!
Guenter
prev parent reply other threads:[~2013-01-16 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 22:36 [PATCH v4] hwmon: Driver for Maxim MAX6697 and compatibles Guenter Roeck
2013-01-16 8:53 ` Jean Delvare
2013-01-16 16:35 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116163539.GA27120@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=linux-doc@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).