From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v4] hwmon: Driver for Maxim MAX6697 and compatibles Date: Wed, 16 Jan 2013 08:35:39 -0800 Message-ID: <20130116163539.GA27120@roeck-us.net> References: <1358289387-996-1-git-send-email-linux@roeck-us.net> <20130116095331.2e3769f0@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130116095331.2e3769f0@endymion.delvare> Sender: linux-doc-owner@vger.kernel.org To: Jean Delvare Cc: lm-sensors@lm-sensors.org, Grant Likely , Rob Herring , Rob Landley , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Jan 16, 2013 at 09:53:31AM +0100, Jean Delvare wrote: > On Tue, 15 Jan 2013 14:36:27 -0800, Guenter Roeck wrote: > > Add support for MAX6581, MAX6602, MAX6622, MAX6636, MAX6689, MAX6693, > > MAX6694, MAX6697, MAX6698, and MAX6699 temperature sensors > > > > Signed-off-by: Guenter Roeck > > --- > > (...) > > v4: > > - s/beta/Beta at beginning of sentence in device tree description file > > - Optimize temperature calculation in show_temp_input > > - Accept temperatures up to 255 degrees C (191 degrees C in extended > > temperature mode) for MAX6581 > > - Define reg as int in max6697_init_chip to be able to catch error cases > > - Optimize assignment to data->temp_offset in max6697_init_chip > > - smbus->SMBus in platform_data/max6697.h > > > > Documentation/devicetree/bindings/i2c/max6697.txt | 64 ++ > > Documentation/hwmon/max6697 | 58 ++ > > drivers/hwmon/Kconfig | 11 + > > drivers/hwmon/Makefile | 1 + > > drivers/hwmon/max6697.c | 726 +++++++++++++++++++++ > > include/linux/platform_data/max6697.h | 36 + > > 6 files changed, 896 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i2c/max6697.txt > > create mode 100644 Documentation/hwmon/max6697 > > create mode 100644 drivers/hwmon/max6697.c > > create mode 100644 include/linux/platform_data/max6697.h > > Reviewed-by: Jean Delvare > > Please update lm-sensors' wiki to mention this driver. > Done. Thanks a lot for the review! Guenter