From: Mike Turquette <mturquette@linaro.org>
To: Tomasz Figa <t.figa@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Thomas Abraham <thomas.abraham@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com,
sylvester.nawrocki@gmail.com,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
Date: Mon, 21 Jan 2013 11:07:20 -0800 [thread overview]
Message-ID: <20130121190720.3982.81903@quantum> (raw)
In-Reply-To: <2433961.3Qz5gqDyvb@amdc1227>
Quoting Tomasz Figa (2013-01-21 08:22:39)
> Hi Thomas, Sylwester,
>
> On Monday 21 of January 2013 15:29:16 Sylwester Nawrocki wrote:
> > On 12/30/2012 01:33 AM, Thomas Abraham wrote:
> > > Changes since v4:
> > > - Rebased to linux-3.8-rc1.
> > >
> > > Changes since v3:
> > > - Includes changes suggested by Tomasz Figa <tomasz.figa@gmail.com>
> > >
> > > This patch series migrates the Samsung Exynos4 SoC clock code to adopt
> > > the common clock framework. The use of Samsung specific clock
> > > structures has been removed and all board support code has been
> > > updated. imx-style of clock registration and lookup has been adopted
> > > for device tree based exynos4 platforms.
> > >
> > > This patch series depends on this series:
> > > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14471
> > > .html and this patch
> > > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14472
> > > .html>
> > > Thomas Abraham (12):
> > > clk: samsung: add common clock framework helper functions for
> > > Samsung platforms clk: samsung: add pll clock registration helper
> > > functions
> > > clk: exynos4: register clocks using common clock framework
> > > ARM: Exynos: Rework timer initialization sequence
> > > ARM: Exynos4: Migrate clock support to common clock framework
> > > ARM: dts: add exynos4 clock controller nodes
> > > ARM: dts: add xxti and xusbxti fixed rate clock nodes for exynos4
> > > based platforms ARM: Exynos4: allow legacy board support to specify
> > > xxti and xusbxti clock speed ARM: dts: add clock provider
> > > information for all controllers in Exynos4 SoC ARM: Exynos4: remove
> > > auxdata table from machine file
> > > ARM: Exynos: use fin_pll clock as the tick clock source for mct
> > > ARM: Exynos: add support for mct clock setup
> > >
> > > .../devicetree/bindings/clock/exynos4-clock.txt | 215 +++++++
> > > arch/arm/boot/dts/exynos4.dtsi | 50 ++
> > > arch/arm/boot/dts/exynos4210-origen.dts | 12 +
> > > arch/arm/boot/dts/exynos4210-smdkv310.dts | 12 +
> > > arch/arm/boot/dts/exynos4210.dtsi | 6 +
> > > arch/arm/boot/dts/exynos4412-origen.dts | 12 +
> > > arch/arm/boot/dts/exynos4412-smdk4412.dts | 12 +
> > > arch/arm/boot/dts/exynos4x12.dtsi | 6 +
> > > arch/arm/mach-exynos/Kconfig | 1 +
> > > arch/arm/mach-exynos/Makefile | 3 -
> > > arch/arm/mach-exynos/clock-exynos4.h | 35 -
> > > arch/arm/mach-exynos/clock-exynos4210.c | 188 ------
> > > arch/arm/mach-exynos/clock-exynos4212.c | 192 ------
> > > arch/arm/mach-exynos/common.c | 57 ++-
> > > arch/arm/mach-exynos/common.h | 21 +-
> > > arch/arm/mach-exynos/mach-armlex4210.c | 3 +-
> > > arch/arm/mach-exynos/mach-exynos4-dt.c | 72 +--
> > > arch/arm/mach-exynos/mach-exynos5-dt.c | 2 +-
> > > arch/arm/mach-exynos/mach-nuri.c | 5 +-
> > > arch/arm/mach-exynos/mach-origen.c | 5 +-
> > > arch/arm/mach-exynos/mach-smdk4x12.c | 5 +-
> > > arch/arm/mach-exynos/mach-smdkv310.c | 7 +-
> > > arch/arm/mach-exynos/mach-universal_c210.c | 3 +-
> > > arch/arm/mach-exynos/mct.c | 32 +-
> > > arch/arm/plat-samsung/Kconfig | 4 +-
> > > drivers/clk/Makefile | 1 +
> > > drivers/clk/samsung/Makefile | 6 +
> > > drivers/clk/samsung/clk-exynos4.c | 655
> > > ++++++++++++++++++++ drivers/clk/samsung/clk-pll.c
> > > | 400 ++++++++++++ drivers/clk/samsung/clk-pll.h
> > > | 38 ++
> > > drivers/clk/samsung/clk.c | 180 ++++++
> > > drivers/clk/samsung/clk.h | 216 +++++++
> > > 32 files changed, 1919 insertions(+), 537 deletions(-)
> > > create mode 100644
> > > Documentation/devicetree/bindings/clock/exynos4-clock.txt delete
> > > mode 100644 arch/arm/mach-exynos/clock-exynos4.h
> > > delete mode 100644 arch/arm/mach-exynos/clock-exynos4210.c
> > > delete mode 100644 arch/arm/mach-exynos/clock-exynos4212.c
> > > create mode 100644 drivers/clk/samsung/Makefile
> > > create mode 100644 drivers/clk/samsung/clk-exynos4.c
> > > create mode 100644 drivers/clk/samsung/clk-pll.c
> > > create mode 100644 drivers/clk/samsung/clk-pll.h
> > > create mode 100644 drivers/clk/samsung/clk.c
> > > create mode 100644 drivers/clk/samsung/clk.h
> >
> > Thanks Thomas! The patch series generally looks good to me, I've tested
> > it on an Exynos4412 based board. I have applied couple fixes that Tomasz
> > Figa has sent you off the mailing list. And to make a MIPI-CSI2 camera
> > working a small fixup patch as below.
> >
> > I have just one remark, but this could possibly be done as a follow up
> > patch. Namely it may make sense to rename various sclk_* clocks to just
> > "sclk", so for instance we don't have "fimd", "sclk_fimd", "fimc",
> > "sclk_fimc" but e.g. "bus" or "gate" and "sclk" for each device. Such
> > naming might be better for handling devices at core subsystems level,
> > e.g. Runtime PM or devfreq.
> >
> > Please feel free to add:
> >
> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Tested-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> I fully agree with Sylwester. After adding mentioned fixup patches, feel
> free to add my Reviewed-by and Tested-by as well.
>
> >
> > I would be great to have this patch set merged for 3.9, so people can
> > switch earlier to the common clock API, rather than modifying files
> > that will be removed soon.
>
> Yes, it would be great to have this series merged earlier, because it's
> very important for further development of Device Tree support on Samsung
> platforms. Possibly for 3.9 it could be merged as an alternative to the
> legacy clock code and after enough testing legacy code could be dropped in
> next kernel release.
>
I thought that the Exynos4 and Exynos5 ports to the common clk framework
were going to be merged. Is that still the plan?
Regards,
Mike
> Best regards
> --
> Tomasz Figa
> Samsung Poland R&D Center
> SW Solution Development, Linux Platform
prev parent reply other threads:[~2013-01-21 19:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-30 0:33 [PATCH v5 00/12] clk: exynos4: migrate to common clock framework Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 01/12] clk: samsung: add common clock framework helper functions for Samsung platforms Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 02/12] clk: samsung: add pll clock registration helper functions Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 03/12] clk: exynos4: register clocks using common clock framework Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 04/12] ARM: Exynos: Rework timer initialization sequence Thomas Abraham
[not found] ` <1356827621-27617-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-12-30 0:33 ` [PATCH v5 05/12] ARM: Exynos4: Migrate clock support to common clock framework Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 06/12] ARM: dts: add exynos4 clock controller nodes Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 07/12] ARM: dts: add xxti and xusbxti fixed rate clock nodes for exynos4 based platforms Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 08/12] ARM: Exynos4: allow legacy board support to specify xxti and xusbxti clock speed Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 09/12] ARM: dts: add clock provider information for all controllers in Exynos4 SoC Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 10/12] ARM: Exynos4: remove auxdata table from machine file Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 11/12] ARM: Exynos: use fin_pll clock as the tick clock source for mct Thomas Abraham
2012-12-30 0:33 ` [PATCH v5 12/12] ARM: Exynos: add support for mct clock setup Thomas Abraham
2012-12-30 5:29 ` [PATCH v5 00/12] clk: exynos4: migrate to common clock framework Olof Johansson
2012-12-31 1:37 ` Kukjin Kim
2013-01-02 19:35 ` Olof Johansson
2012-12-31 5:35 ` Thomas Abraham
2013-01-02 19:33 ` Olof Johansson
2013-01-21 14:29 ` Sylwester Nawrocki
2013-01-21 16:22 ` Tomasz Figa
2013-01-21 19:07 ` Mike Turquette [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121190720.3982.81903@quantum \
--to=mturquette@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).