devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: "swarren@nvidia.com" <swarren@nvidia.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	"johnstul@us.ibm.com" <johnstul@us.ibm.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init
Date: Tue, 22 Jan 2013 11:04:56 +0000	[thread overview]
Message-ID: <20130122110456.GC18876@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <CAJuYYwSfH8jTterd6aNc_Aw81PBschfCUf=REKB35=Y4a=i_7A@mail.gmail.com>

On Mon, Jan 21, 2013 at 06:30:47PM +0000, Thomas Abraham wrote:
> Hi Stephen,
> 
> On 21 January 2013 09:21, Stephen Warren <swarren@wwwdotorg.org> wrote:
> > On 01/20/2013 06:22 PM, Thomas Abraham wrote:
> >> Add an entry in __clksrc_of_table so that ARMv7 architected timer is
> >> discoverable using call to clocksource_of_init.
> >
> >> diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
> >
> >> +#ifdef CONFIG_CLKSRC_OF
> >> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer", arch_timer_of_register)
> >> +#endif
> >
> > I wonder if we shouldn't enhance include/linux/clocksource.h to define
> > CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers
> > wouldn't need that ifdef.
> 
> Yes, it will be helpful to have a !CONFIG_CLKSRC_OF version of
> CLOCKSOURCE_OF_DECLARE. And can CONFIG_CLKSRC_OF be enabled by default
> for all ARM platforms?
> 
> Thanks,
> Thomas.

Thomas,

Once the above is worked out, could you send me the updated patch with a
pointer to whichever {branch,patch}(es) I need for CLKSRC_OF?

Thanks,
Mark.

  reply	other threads:[~2013-01-22 11:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-21  1:22 [PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init Thomas Abraham
2013-01-21 12:13 ` Mark Rutland
     [not found]   ` <20130121121353.GH15707-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-01-21 18:19     ` Thomas Abraham
     [not found] ` <1358731326-2979-1-git-send-email-thomas.abraham-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-01-21 17:21   ` Stephen Warren
2013-01-21 18:25     ` Marc Zyngier
     [not found]     ` <50FD7904.1070201-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-21 18:30       ` Thomas Abraham
2013-01-22 11:04         ` Mark Rutland [this message]
2013-01-30 17:19           ` Mark Rutland
2013-01-30 17:49             ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130122110456.GC18876@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).