From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dongjin Kim <tobetter@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Fengguang Wu <fengguang.wu@intel.com>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: misc: usb3503: add dt support
Date: Thu, 24 Jan 2013 14:03:03 -0800 [thread overview]
Message-ID: <20130124220303.GA30869@kroah.com> (raw)
In-Reply-To: <1358963242-2596-1-git-send-email-tobetter@gmail.com>
On Thu, Jan 24, 2013 at 02:47:10AM +0900, Dongjin Kim wrote:
> Added device tree support for usb3503 driver and add new document with device tree binding information.
>
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
> ---
> Documentation/devicetree/bindings/usb/usb3503.txt | 20 +++++++++++++
> drivers/usb/misc/usb3503.c | 31 +++++++++++++++++----
> 2 files changed, 46 insertions(+), 5 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/usb/usb3503.txt
I've applied this, but now we have the compiler warning:
drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
drivers/usb/misc/usb3503.c:215:13: warning: ‘mode’ may be used uninitialized in this function [-Wuninitialized]
Please send a follow-on patch to fix this up.
greg k-h
prev parent reply other threads:[~2013-01-24 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 17:47 [PATCH] USB: misc: usb3503: add dt support Dongjin Kim
2013-01-24 22:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124220303.GA30869@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fengguang.wu@intel.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).