From: Arnd Bergmann <arnd@arndb.de>
To: devicetree-discuss@lists.ozlabs.org
Cc: Padmavathi Venna <padma.v@samsung.com>,
padma.kvr@gmail.com, linux-samsung-soc@vger.kernel.org,
alsa-devel@alsa-project.org, jassisinghbrar@gmail.com,
kgene.kim@samsung.com, swarren@nvidia.com,
boojin.kim@samsung.com, sbkim73@samsung.com,
broonie@opensource.wolfsonmicro.com, vinod.koul@intel.com
Subject: Re: [PATCH 2/4] DMA: PL330: Register the DMA controller with the generic DMA helpers
Date: Mon, 28 Jan 2013 14:51:00 +0000 [thread overview]
Message-ID: <201301281451.00364.arnd@arndb.de> (raw)
In-Reply-To: <1358508824-20352-3-git-send-email-padma.v@samsung.com>
On Friday 18 January 2013, Padmavathi Venna wrote:
> + pfi = devm_kzalloc(&adev->dev, sizeof(*pfi), GFP_KERNEL);
> + if (!pfi) {
> + dev_err(&adev->dev, "unable to allocate mem\n");
> + return -ENOMEM;
> + }
> +
> + pfi->dma_cap = pd->cap_mask;
> + pfi->filter_fn = pl330_filter;
> +
> + ret = of_dma_controller_register(adev->dev.of_node,
> + of_dma_pl330_xlate, pfi);
Why do you pass a 'struct of_dma_filter_info' here? I would
expect that you pass the pdmac object as the third argument.
Arnd
next prev parent reply other threads:[~2013-01-28 14:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 11:33 [PATCH 0/4] Add generic DMA DT binding support Padmavathi Venna
2013-01-18 11:33 ` [PATCH 1/4] DMA: PL330: Add xlate function Padmavathi Venna
2013-01-28 14:58 ` Arnd Bergmann
2013-01-29 9:03 ` Padma Venkat
2013-01-29 10:27 ` Arnd Bergmann
2013-01-18 11:33 ` [PATCH 2/4] DMA: PL330: Register the DMA controller with the generic DMA helpers Padmavathi Venna
2013-01-28 14:51 ` Arnd Bergmann [this message]
2013-01-28 17:54 ` Jon Hunter
2013-01-28 18:01 ` Arnd Bergmann
2013-01-28 21:11 ` Jon Hunter
2013-01-18 11:33 ` [PATCH 3/4] ARM: dts: Add #dma-cells for generic dma binding support Padmavathi Venna
2013-01-28 14:47 ` Arnd Bergmann
2013-01-29 8:53 ` Padma Venkat
2013-01-18 11:33 ` [PATCH 4/4] DMA: PL330: Modify pl330 filter based on new generic dma dt bindings Padmavathi Venna
2013-01-28 13:43 ` [PATCH 0/4] Add generic DMA DT binding support Vinod Koul
2013-01-28 15:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301281451.00364.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=boojin.kim@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
--cc=swarren@nvidia.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).