From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Naveen Krishna Chatradhi
<ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2 4/4] iio: Add OF support
Date: Mon, 4 Feb 2013 08:37:04 -0800 [thread overview]
Message-ID: <20130204163704.GA18187@roeck-us.net> (raw)
In-Reply-To: <20130203162213.GA21576-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On Sun, Feb 03, 2013 at 08:22:13AM -0800, Guenter Roeck wrote:
[ ... ]
> > > +
> > > + /* NULL terminated array to save passing size */
> > > + chans = kzalloc(sizeof(*chans)*(nummaps + 1), GFP_KERNEL);
> >
> > I think using kcalloc makes sense here.
> >
> that would leave chan->data uninitialized, and I would have to initialize it
> explicitly. also, if additional fields are ever added, we would risk having
> uninitialized fields. Using kzalloc avoids a potential future error case, so I
> would prefer to keep it.
>
Please ignore this one.
Looks like my brain was too flu-foggy to realize that kcalloc does clear the
memory.
Guenter
prev parent reply other threads:[~2013-02-04 16:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 0:59 [RFC v2 0/4] iio: Devicetree support Guenter Roeck
[not found] ` <1359853180-5664-1-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-03 0:59 ` [PATCH 1/4] iio: max1363: Use devm_ functions whereever possible to allocate resources Guenter Roeck
[not found] ` <1359853180-5664-2-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-03 12:10 ` Jonathan Cameron
[not found] ` <510E53B8.40803-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-02-03 17:18 ` Guenter Roeck
[not found] ` <20130203171852.GA29574-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-03 18:02 ` Jonathan Cameron
[not found] ` <510EA651.6040509-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-02-03 18:16 ` Guenter Roeck
2013-02-03 0:59 ` [PATCH v2 2/4] iio/adc: (max1363) Add support for external reference voltage Guenter Roeck
[not found] ` <1359853180-5664-3-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-03 12:12 ` Jonathan Cameron
2013-02-03 0:59 ` [PATCH RFC 3/4] iio: Update iio_channel_get API to use consumer device pointer as argument Guenter Roeck
2013-02-03 0:59 ` [PATCH v2 4/4] iio: Add OF support Guenter Roeck
[not found] ` <1359853180-5664-5-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-03 1:30 ` Tomasz Figa
2013-02-03 2:06 ` Guenter Roeck
[not found] ` <20130203020651.GA7655-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-03 11:29 ` Lars-Peter Clausen
[not found] ` <510E4A13.3080800-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-02-03 11:52 ` Tomasz Figa
2013-02-03 12:22 ` Lars-Peter Clausen
2013-02-03 17:01 ` Guenter Roeck
[not found] ` <20130203170107.GD21576-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-03 17:30 ` Tomasz Figa
2013-02-03 18:55 ` Lars-Peter Clausen
[not found] ` <510EB2B3.7090503-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-02-03 20:58 ` Jonathan Cameron
[not found] ` <510ECF91.8020800-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-02-03 22:44 ` Lars-Peter Clausen
2013-02-03 23:14 ` Tomasz Figa
2013-02-04 17:12 ` Guenter Roeck
[not found] ` <20130204171214.GA23170-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-04 17:41 ` Lars-Peter Clausen
2013-02-04 17:51 ` Guenter Roeck
[not found] ` <20130204175134.GA17776-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-04 18:00 ` Tomasz Figa
2013-02-04 18:09 ` Guenter Roeck
2013-02-03 16:31 ` Guenter Roeck
[not found] ` <20130203163124.GC21576-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-03 19:00 ` Lars-Peter Clausen
2013-02-03 14:17 ` Lars-Peter Clausen
[not found] ` <510E7195.4070803-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-02-03 16:22 ` Guenter Roeck
[not found] ` <20130203162213.GA21576-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-02-04 16:37 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204163704.GA18187@roeck-us.net \
--to=linux-0h96xk9xttrk1umjsbkqmq@public.gmane.org \
--cc=ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).