From: Grant Likely <grant.likely@secretlab.ca>
To: Stephen Warren <swarren@wwwdotorg.org>, Simon Glass <sjg@chromium.org>
Cc: Roland Stigge <stigge@antcom.de>,
Vincent Palatin <vpalatin@chromium.org>,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, Felipe Balbi <balbi@ti.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Luigi Semenzato <semenzato@chromium.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Rob Herring <rob.herring@calxeda.com>,
linux-input@vger.kernel.org, Stephen Warren <swarren@nvidia.com>,
Sourav Poddar <sourav.poddar@ti.com>,
Alban Bedel <alban.bedel@avionic-design.de>
Subject: Re: [PATCH v2] input: Extend matrix-keypad device tree binding
Date: Fri, 08 Feb 2013 12:59:24 +0000 [thread overview]
Message-ID: <20130208125924.65E803E2B73@localhost> (raw)
In-Reply-To: <50F0473F.404@wwwdotorg.org>
On Fri, 11 Jan 2013 10:09:19 -0700, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 01/10/2013 06:41 PM, Simon Glass wrote:
> > Some matrix keypad drivers can support different numbers of rows and
> > columns. Add a generic binding for these.
> >
> > Implementation note:
> >
> > In order to implement this binding in the kernel, we will need to modify
> > matrix_keypad_() to look up the number of rows and cols in
> > the keymap. Perhaps this could be done by passing 0 for these parameters?
> > Many of the parameters can already be set to NULL. Ick.
>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
Applied, thanks.
g.
prev parent reply other threads:[~2013-02-08 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 1:41 [PATCH v2] input: Extend matrix-keypad device tree binding Simon Glass
2013-01-11 17:09 ` Stephen Warren
2013-01-11 17:13 ` Dmitry Torokhov
2013-02-08 12:59 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208125924.65E803E2B73@localhost \
--to=grant.likely@secretlab.ca \
--cc=alban.bedel@avionic-design.de \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=semenzato@chromium.org \
--cc=sjg@chromium.org \
--cc=sourav.poddar@ti.com \
--cc=stigge@antcom.de \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=vpalatin@chromium.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).