From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver Date: Sat, 9 Feb 2013 10:52:33 +0000 Message-ID: <20130209105233.GI17852@n2100.arm.linux.org.uk> References: <1360184596-1603-1-git-send-email-jon-hunter@ti.com> <1360184596-1603-3-git-send-email-jon-hunter@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1360184596-1603-3-git-send-email-jon-hunter@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Jon Hunter Cc: Rob Herring , Grant Likely , Tony Lindgren , Benoit Cousson , Vinod Koul , device-tree , linux-omap , linux-arm , Santosh Shilimkar , Matt Porter , Felipe Balbi , Sourav Poddar , Balaji T K List-Id: devicetree@vger.kernel.org On Wed, Feb 06, 2013 at 03:03:16PM -0600, Jon Hunter wrote: > @@ -673,7 +702,7 @@ static int omap_dma_init(void) > { > int rc = platform_driver_register(&omap_dma_driver); > > - if (rc == 0) { > + if ((rc == 0) && (!of_have_populated_dt())) { Looks good, the worst I can find is this over-use of parens...