From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Andreas Larsson <andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
Cc: software-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH v2 4/6] of_spi: Document cs_gpios and cs_gpio in kernel-doc
Date: Mon, 11 Feb 2013 00:06:15 +0000 [thread overview]
Message-ID: <20130211000615.2BD4A3E0C13@localhost> (raw)
In-Reply-To: <1359471223-4794-5-git-send-email-andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
On Tue, 29 Jan 2013 15:53:41 +0100, Andreas Larsson <andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org> wrote:
> This adds missing kernel-doc entries for cs_gpios in struct spi_master and
> cs_gpio in struct spi_device.
>
> Signed-off-by: Andreas Larsson <andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
Applied, thanks. I did tweak the language a bit.
g.
> ---
> include/linux/spi/spi.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
> index f629189..88a669c 100644
> --- a/include/linux/spi/spi.h
> +++ b/include/linux/spi/spi.h
> @@ -57,6 +57,7 @@ extern struct bus_type spi_bus_type;
> * @modalias: Name of the driver to use with this device, or an alias
> * for that name. This appears in the sysfs "modalias" attribute
> * for driver coldplugging, and in uevents used for hotplugging
> + * @cs_gpio: Negative or gpio for chip select.
> *
> * A @spi_device is used to interchange data between an SPI slave
> * (usually a discrete chip) and CPU memory.
> @@ -258,6 +259,7 @@ static inline void spi_unregister_driver(struct spi_driver *sdrv)
> * @unprepare_transfer_hardware: there are currently no more messages on the
> * queue so the subsystem notifies the driver that it may relax the
> * hardware by issuing this call
> + * @cs_gpios: possible array of negative values or gpios for chip selects
> *
> * Each SPI master controller can communicate with one or more @spi_device
> * children. These make a small bus, sharing MOSI, MISO and SCK signals
> --
> 1.7.0.4
>
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
next prev parent reply other threads:[~2013-02-11 0:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 14:53 [PATCH v2 0/6] of, of_gpio, of_spi: Bugfix and improve of_parse_phandle_with_args, of_gpio_named_count and of_spi_register_master Andreas Larsson
[not found] ` <1359471223-4794-1-git-send-email-andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
2013-01-29 14:53 ` [PATCH v2 1/6] of: Return -EEXIST from of_parse_phandle_with_args for holes in phandle list Andreas Larsson
2013-01-29 14:53 ` [PATCH v2 2/6] of: Return -ENXIO from of_parse_phandle_with_args for too large index and return errors from of_gpio_named_count Andreas Larsson
[not found] ` <1359471223-4794-3-git-send-email-andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
2013-02-01 9:37 ` Linus Walleij
2013-02-10 23:56 ` Grant Likely
2013-01-29 14:53 ` [PATCH v2 3/6] of_spi: Initialize cs_gpios properly Andreas Larsson
2013-02-11 0:00 ` Grant Likely
2013-01-29 14:53 ` [PATCH v2 4/6] of_spi: Document cs_gpios and cs_gpio in kernel-doc Andreas Larsson
[not found] ` <1359471223-4794-5-git-send-email-andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org>
2013-02-11 0:06 ` Grant Likely [this message]
2013-01-29 14:53 ` [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master Andreas Larsson
2013-02-11 0:22 ` Grant Likely
2013-02-12 9:39 ` Andreas Larsson
2013-02-12 17:09 ` Grant Likely
2013-01-29 14:53 ` [PATCH v2 6/6] of_spi: Initialize cs_gpios and cs_gpio with -EEXIST Andreas Larsson
2013-02-11 0:23 ` Grant Likely
2013-02-12 9:46 ` Andreas Larsson
2013-02-12 18:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211000615.2BD4A3E0C13@localhost \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=andreas-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=software-FkzTOoA/JUlBDgjK7y7TUQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).